From: Andrew Lunn <andrew@lunn.ch>
To: Troy Kisky <troy.kisky@boundarydevices.com>
Cc: shawn.guo@linaro.org, fugang.duan@nxp.com,
netdev@vger.kernel.org, davem@davemloft.net,
fabio.estevam@nxp.com, lznuaa@gmail.com
Subject: Re: [PATCH net v2 1/2] ARM: dts: imx: name the interrupts for the fec ethernet driver
Date: Sat, 14 Oct 2017 20:50:18 +0200 [thread overview]
Message-ID: <20171014185018.GD18578@lunn.ch> (raw)
In-Reply-To: <20171014020940.32736-1-troy.kisky@boundarydevices.com>
On Fri, Oct 13, 2017 at 07:09:39PM -0700, Troy Kisky wrote:
> imx7s/imx7d has the ptp interrupt newly added as well.
Hi Troy
> For imx7, "int0" is the interrupt for queue 0 and ENET_MII
> "int1" is for queue 1
> "int2" is for queue 2
Thanks for adding this explanation. Please also add it to
Documentation/devicetree/bindings/net/fsl-fec.txt
> fec: ethernet@02188000 {
> compatible = "fsl,imx6q-fec";
> reg = <0x02188000 0x4000>;
> + interrupt-names = "int0","ptp";
It is normal to have a space after the ,
Andrew
prev parent reply other threads:[~2017-10-14 18:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-14 2:09 [PATCH net v2 1/2] ARM: dts: imx: name the interrupts for the fec ethernet driver Troy Kisky
2017-10-14 2:09 ` [PATCH net v2 2/2] net: fec: Let fec_ptp have its own interrupt routine Troy Kisky
2017-10-16 3:41 ` Andy Duan
2017-10-17 21:33 ` Troy Kisky
2017-10-18 2:30 ` Andy Duan
2017-10-18 18:10 ` Troy Kisky
2017-10-18 18:29 ` Troy Kisky
2017-10-19 6:25 ` Andy Duan
2017-10-14 18:50 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171014185018.GD18578@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=fabio.estevam@nxp.com \
--cc=fugang.duan@nxp.com \
--cc=lznuaa@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).