From: David Miller <davem@davemloft.net>
To: roman@advem.lv
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 00/10] korina cleanups/optimizations
Date: Sun, 15 Oct 2017 14:05:48 -0700 (PDT) [thread overview]
Message-ID: <20171015.140548.812014928035930297.davem@davemloft.net> (raw)
In-Reply-To: <c3a2f516dcceb7dee9ea4dde634b58ed@advem.lv>
From: Roman Yeryomin <roman@advem.lv>
Date: Sun, 15 Oct 2017 19:46:02 +0300
> On 2017-10-15 19:38, Florian Fainelli wrote:
>> On October 15, 2017 9:22:26 AM PDT, Roman Yeryomin <roman@advem.lv>
>> wrote:
>>> TX optimizations have led to ~15% performance increase (35->40Mbps)
>>> in local tx usecase (tested with iperf v3.2).
>> Could you avoid empty commit messages and write a paragraph or two for
>> each commit that explains what and why are you changing? The changes
>> look fine but they lack any explanation.
>
> I thought that short descriptions are already self explanatory and
> just didn't know what to write more.
"Optimize TX handlers."
In what way? Why? How are things improved? Is it measurable?
etc.
next prev parent reply other threads:[~2017-10-15 21:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-15 16:22 [PATCH net-next 00/10] korina cleanups/optimizations Roman Yeryomin
2017-10-15 16:38 ` Florian Fainelli
2017-10-15 16:46 ` Roman Yeryomin
2017-10-15 17:36 ` Florian Fainelli
2017-10-15 21:05 ` David Miller [this message]
2017-10-22 20:57 ` Roman Yeryomin
2017-10-25 6:19 ` Roman Yeryomin
2017-10-16 12:59 ` David Laight
2017-10-22 20:58 ` Roman Yeryomin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171015.140548.812014928035930297.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roman@advem.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).