From: David Miller <davem@davemloft.net>
To: nicolas.dichtel@6wind.com
Cc: dsahern@gmail.com, netdev@vger.kernel.org, oliver@hartkopp.net,
stephen@networkplumber.org
Subject: Re: [PATCH net v3] net: enable interface alias removal via rtnl
Date: Mon, 16 Oct 2017 20:52:57 +0100 (WEST) [thread overview]
Message-ID: <20171016.205257.457189372417045427.davem@davemloft.net> (raw)
In-Reply-To: <20171011142448.31707-1-nicolas.dichtel@6wind.com>
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Wed, 11 Oct 2017 16:24:48 +0200
> IFLA_IFALIAS is defined as NLA_STRING. It means that the minimal length of
> the attribute is 1 ("\0"). However, to remove an alias, the attribute
> length must be 0 (see dev_set_alias()).
>
> Let's define the type to NLA_BINARY to allow 0-length string, so that the
> alias can be removed.
>
> Example:
> $ ip l s dummy0 alias foo
> $ ip l l dev dummy0
> 5: dummy0: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
> link/ether ae:20:30:4f:a7:f3 brd ff:ff:ff:ff:ff:ff
> alias foo
>
> Before the patch:
> $ ip l s dummy0 alias ""
> RTNETLINK answers: Numerical result out of range
>
> After the patch:
> $ ip l s dummy0 alias ""
> $ ip l l dev dummy0
> 5: dummy0: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
> link/ether ae:20:30:4f:a7:f3 brd ff:ff:ff:ff:ff:ff
>
> CC: Oliver Hartkopp <oliver@hartkopp.net>
> CC: Stephen Hemminger <stephen@networkplumber.org>
> Fixes: 96ca4a2cc145 ("net: remove ifalias on empty given alias")
> Reported-by: Julien FLoret <julien.floret@6wind.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Applied, thank you.
prev parent reply other threads:[~2017-10-16 19:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 10:19 [PATCH net] net: enable interface alias removal via rtnl Nicolas Dichtel
2017-10-06 18:18 ` David Ahern
2017-10-06 20:10 ` Oliver Hartkopp
2017-10-09 8:23 ` Nicolas Dichtel
2017-10-09 14:02 ` David Ahern
2017-10-09 15:25 ` Nicolas Dichtel
2017-10-09 21:17 ` David Ahern
2017-10-10 12:41 ` [PATCH net v2] " Nicolas Dichtel
2017-10-10 14:50 ` David Ahern
2017-10-11 12:29 ` Nicolas Dichtel
2017-10-11 14:13 ` David Ahern
2017-10-11 14:24 ` [PATCH net v3] " Nicolas Dichtel
2017-10-16 19:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016.205257.457189372417045427.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=oliver@hartkopp.net \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).