netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Humberto Alves <hjalves@live.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [iproute2] regression in ss output
Date: Mon, 16 Oct 2017 12:33:20 +0200	[thread overview]
Message-ID: <20171016103320.GP11332@orbyte.nwl.cc> (raw)
In-Reply-To: <AM4PR0901MB125261BF480B49D2BA2DF46BCC480@AM4PR0901MB1252.eurprd09.prod.outlook.com>

Hi,

On Fri, Oct 13, 2017 at 09:57:37AM +0000, Humberto Alves wrote:
> Hi! With the last iproute2 release, ss command output does not 
> differentiate between any-address IPv4 sockets from the IPv6 ones.
> I don't know if this is an expected behaviour, but the old output looks 
> more useful. Below I pasted the difference between the old behaviour and 
> the new one.

Although the change is certainly intentional (it was introduced by
Stephen Hemminger as a side effect of aba9c23a6e1cb ("ss: enclose IPv6
address in brackets"), I second reverting to the old display of
in6addr_any as '::'.

> I am happy to send a patch if you want. Thanks

It should be enough to just getting rid of the

| if (!memcmp(a->data, &in6addr_any, sizeof(in6addr_any))) {

case in inet_addr_print(). The else-case which calls format_host()
should deal with in6addr_any just fine. This way the address also gets
enclosed in brackets which helps separating it from the ':port' part.

Cheers, Phil

  reply	other threads:[~2017-10-16 10:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-13  9:57 [iproute2] regression in ss output Humberto Alves
2017-10-16 10:33 ` Phil Sutter [this message]
2017-10-16 20:44   ` Humberto Alves
2017-10-16 21:28     ` Stephen Hemminger
2017-10-17  2:00       ` Eric Dumazet
     [not found]         ` <20171016194958.669625db@xeon-e3>
2017-10-18 14:08           ` Humberto Alves
2017-10-18 14:17             ` Eric Dumazet
2017-10-18 17:11           ` Phil Sutter
2017-10-18 17:58           ` [iproute PATCH] ss: Distinguish between IPv4 and IPv6 wildcard sockets Phil Sutter
2017-10-23 12:41             ` Stephen Hemminger
2017-10-16 16:20 ` [iproute2] regression in ss output Stephen Hemminger
2017-10-16 20:34   ` Humberto Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171016103320.GP11332@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=hjalves@live.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).