From: Andrew Lunn <andrew@lunn.ch>
To: "Martin Hundebøll" <mnhu@prevas.dk>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next] dsa: slave: support phy devices on external MII bus
Date: Mon, 16 Oct 2017 15:39:43 +0200 [thread overview]
Message-ID: <20171016133943.GA7802@lunn.ch> (raw)
In-Reply-To: <02997de6-1c8a-d69b-d19b-3a811288e8ed@prevas.dk>
On Mon, Oct 16, 2017 at 03:16:51PM +0200, Martin Hundebøll wrote:
> On 2017-10-16 14:32, Andrew Lunn wrote:
> >So this used to work. I have a 10G phy connected to the external MII
> >bus on a 6390. I wonder when this got broken? Supporting phy-handle is
> >old code, so when i added the external MII i don't think i needed to
> >change any generic code.
>
> It could look like commit cd28a1a9baee7 ('net: dsa: fully divert PHY
> reads/writes if requested') changed the of-case to use the mdio bus
> associated with struct dsa_switch unconditionally.
Hi Martin
I think ds->phys_mii_mask is playing a role here. I need to add some
debug prints to my setup and see what is happening with my external
10G PHY.
This phy code is just too complex :-(
Andrew
next prev parent reply other threads:[~2017-10-16 13:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 10:45 [PATCH net-next] dsa: slave: support phy devices on external MII bus Martin Hundebøll
2017-10-16 12:32 ` Andrew Lunn
2017-10-16 12:56 ` Martin Hundebøll
2017-10-16 13:16 ` Martin Hundebøll
2017-10-16 13:39 ` Andrew Lunn [this message]
2017-10-16 14:16 ` Florian Fainelli
2017-10-16 12:40 ` Andrew Lunn
2017-10-16 12:48 ` Martin Hundebøll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016133943.GA7802@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=mnhu@prevas.dk \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).