From: Richard Weinberger <richard@nod.at>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, daniel@iogearbox.net,
ast@kernel.org, Richard Weinberger <richard@nod.at>
Subject: [PATCH 1/3] bpf: Don't check for current being NULL
Date: Mon, 16 Oct 2017 20:18:54 +0200 [thread overview]
Message-ID: <20171016181856.12497-1-richard@nod.at> (raw)
current is never NULL.
Signed-off-by: Richard Weinberger <richard@nod.at>
---
kernel/bpf/helpers.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c
index 3d24e238221e..e8845adcd15e 100644
--- a/kernel/bpf/helpers.c
+++ b/kernel/bpf/helpers.c
@@ -120,9 +120,6 @@ BPF_CALL_0(bpf_get_current_pid_tgid)
{
struct task_struct *task = current;
- if (unlikely(!task))
- return -EINVAL;
-
return (u64) task->tgid << 32 | task->pid;
}
@@ -138,9 +135,6 @@ BPF_CALL_0(bpf_get_current_uid_gid)
kuid_t uid;
kgid_t gid;
- if (unlikely(!task))
- return -EINVAL;
-
current_uid_gid(&uid, &gid);
return (u64) from_kgid(&init_user_ns, gid) << 32 |
from_kuid(&init_user_ns, uid);
@@ -156,9 +150,6 @@ BPF_CALL_2(bpf_get_current_comm, char *, buf, u32, size)
{
struct task_struct *task = current;
- if (unlikely(!task))
- goto err_clear;
-
strncpy(buf, task->comm, size);
/* Verifier guarantees that size > 0. For task->comm exceeding
@@ -167,9 +158,6 @@ BPF_CALL_2(bpf_get_current_comm, char *, buf, u32, size)
*/
buf[size - 1] = 0;
return 0;
-err_clear:
- memset(buf, 0, size);
- return -EINVAL;
}
const struct bpf_func_proto bpf_get_current_comm_proto = {
--
2.13.6
next reply other threads:[~2017-10-16 18:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 18:18 Richard Weinberger [this message]
2017-10-16 18:18 ` [PATCH 2/3] bpf: Remove dead variable Richard Weinberger
2017-10-16 18:54 ` Daniel Borkmann
2017-10-16 18:59 ` Richard Weinberger
2017-10-16 19:11 ` Daniel Borkmann
2017-10-16 19:22 ` Richard Weinberger
2017-10-16 20:48 ` Daniel Borkmann
2017-10-16 18:18 ` [PATCH 3/3] bpf: Make sure that ->comm does not change under us Richard Weinberger
2017-10-16 20:50 ` Daniel Borkmann
2017-10-16 20:55 ` Richard Weinberger
2017-10-16 21:02 ` Daniel Borkmann
2017-10-16 21:10 ` Richard Weinberger
-- strict thread matches above, loose matches on Subject: below --
2017-10-16 22:06 [PATCH 1/3] bpf: Don't check for current being NULL Alexei Starovoitov
2017-10-16 22:23 ` Richard Weinberger
2017-10-16 22:31 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016181856.12497-1-richard@nod.at \
--to=richard@nod.at \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).