From: David Miller <davem@davemloft.net>
To: henrik@austad.us
Cc: netdev@vger.kernel.org, edumazet@google.com,
daniel@iogearbox.net, dsahern@gmail.com,
alexander.h.duyck@intel.com, willemb@google.com,
john.fastabend@gmail.com, me@tobin.cc,
linux-kernel@vger.kernel.org, haustad@cisco.com,
jesus.sanchez-palencia@intel.com
Subject: Re: [PATCH] net: export netdev_txq_to_tc to allow sch_mqprio to compile as module
Date: Tue, 17 Oct 2017 17:00:42 +0100 (WEST) [thread overview]
Message-ID: <20171017.170042.1711156550393094740.davem@davemloft.net> (raw)
In-Reply-To: <1508235010-4056-1-git-send-email-haustad@cisco.com>
From: Henrik Austad <henrik@austad.us>
Date: Tue, 17 Oct 2017 12:10:10 +0200
> In commit 32302902ff09 ("mqprio: Reserve last 32 classid values for HW
> traffic classes and misc IDs") sch_mqprio started using netdev_txq_to_tc
> to find the correct tc instead of dev->tc_to_txq[]
>
> However, when mqprio is compiled as a module, it cannot resolve the
> symbol, leading to this error:
>
> ERROR: "netdev_txq_to_tc" [net/sched/sch_mqprio.ko] undefined!
>
> This adds an EXPORT_SYMBOL() since the other user in the kernel
> (netif_set_xps_queue) is also EXPORT_SYMBOL() (and not _GPL) or in a
> sysfs-callback.
>
> Cc: Alexander Duyck <alexander.h.duyck@intel.com>
> Cc: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Henrik Austad <haustad@cisco.com>
Applied, thanks.
prev parent reply other threads:[~2017-10-17 16:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 10:10 [PATCH] net: export netdev_txq_to_tc to allow sch_mqprio to compile as module Henrik Austad
2017-10-17 11:21 ` Eric Dumazet
2017-10-17 14:31 ` Duyck, Alexander H
2017-10-17 16:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017.170042.1711156550393094740.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=haustad@cisco.com \
--cc=henrik@austad.us \
--cc=jesus.sanchez-palencia@intel.com \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).