From: Henrik Austad <henrik@austad.us>
To: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
andre.guedes@intel.com, ivan.briano@intel.com,
jesus.sanchez-palencia@intel.com, boon.leong.ong@intel.com,
richardcochran@gmail.com, levipearson@gmail.com,
rodney.cummings@ni.com
Subject: Re: [next-queue PATCH v9 0/6] TSN: Add qdisc based config interface for CBS
Date: Tue, 17 Oct 2017 13:35:50 +0200 [thread overview]
Message-ID: <20171017113550.GA17834@sisyphus.home.austad.us> (raw)
In-Reply-To: <20171017010128.22141-1-vinicius.gomes@intel.com>
[-- Attachment #1: Type: text/plain, Size: 967 bytes --]
On Mon, Oct 16, 2017 at 06:01:22PM -0700, Vinicius Costa Gomes wrote:
> Hi,
Vinicius; this looks really good to me, testing shows no errors and
behavior is as expected. I see some differences in received bw for
offload=1 and 0 though
Just using tsn_talker and tsn_listener:
tc qdisc add dev eth2 parent 8001:1 cbs idleslope 20000 sendslope -980000 \
hicredit 30 locredit -1470 offload 1
with offload=1 (20Mbps BW)
Receiving data rate: 19420 kbps
Receiving data rate: 19410 kbps
Similarly, but with offload=0 (SW, 20Mbps BW)
Receiving data rate: 19980 kbps
Receiving data rate: 20170 kbps
So slightly higer variance in rate when doing SW, which is as expected.
I plan to run this through some more tests tomorrow and measure variance on the
receiver etc, I'll keep you posted on my findings.
Feel free to add a tested-by though
Tested-by: Henrik Austad <henrik@austad.us>
and a Vehemently-supported-by: Henrik .. :)
-Henrik
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2017-10-17 11:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 1:01 [next-queue PATCH v9 0/6] TSN: Add qdisc based config interface for CBS Vinicius Costa Gomes
2017-10-17 1:01 ` [next-queue PATCH v9 1/6] net/sched: Check for null dev_queue on create flow Vinicius Costa Gomes
2017-10-17 1:01 ` [next-queue PATCH v9 2/6] net/sched: Change behavior of mq select_queue() Vinicius Costa Gomes
2017-10-17 1:01 ` [next-queue PATCH v9 3/6] net/sched: Add select_queue() class_ops for mqprio Vinicius Costa Gomes
2017-10-17 1:01 ` [next-queue PATCH v9 4/6] net/sched: Introduce Credit Based Shaper (CBS) qdisc Vinicius Costa Gomes
2017-10-17 1:01 ` [next-queue PATCH v9 5/6] net/sched: Add support for HW offloading for CBS Vinicius Costa Gomes
2017-10-17 1:01 ` [next-queue PATCH v9 6/6] igb: Add support for CBS offload Vinicius Costa Gomes
2017-10-20 1:47 ` [Intel-wired-lan] " Brown, Aaron F
2017-10-17 11:35 ` Henrik Austad [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017113550.GA17834@sisyphus.home.austad.us \
--to=henrik@austad.us \
--cc=andre.guedes@intel.com \
--cc=boon.leong.ong@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=ivan.briano@intel.com \
--cc=jesus.sanchez-palencia@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=levipearson@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=rodney.cummings@ni.com \
--cc=vinicius.gomes@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox