* [PATCH] udp: make some messages more descriptive
@ 2017-10-17 16:48 Matteo Croce
2017-10-19 12:17 ` David Miller
2017-10-19 12:22 ` [PATCH v2] " Matteo Croce
0 siblings, 2 replies; 3+ messages in thread
From: Matteo Croce @ 2017-10-17 16:48 UTC (permalink / raw)
To: netdev
In the UDP code there are two leftover error messages with very few meaning.
Replace them with a more descriptive error message as some users
reported them as "strange network error".
---
net/ipv4/udp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index e45177ceb0ee..806b298a3bdd 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -1061,7 +1061,7 @@ int udp_sendmsg(struct sock *sk, struct msghdr *msg, size_t len)
/* ... which is an evident application bug. --ANK */
release_sock(sk);
- net_dbg_ratelimited("cork app bug 2\n");
+ net_dbg_ratelimited("socket already corked\n");
err = -EINVAL;
goto out;
}
@@ -1144,7 +1144,7 @@ int udp_sendpage(struct sock *sk, struct page *page, int offset,
if (unlikely(!up->pending)) {
release_sock(sk);
- net_dbg_ratelimited("udp cork app bug 3\n");
+ net_dbg_ratelimited("cork failed\n");
return -EINVAL;
}
--
2.13.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] udp: make some messages more descriptive
2017-10-17 16:48 [PATCH] udp: make some messages more descriptive Matteo Croce
@ 2017-10-19 12:17 ` David Miller
2017-10-19 12:22 ` [PATCH v2] " Matteo Croce
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-10-19 12:17 UTC (permalink / raw)
To: mcroce; +Cc: netdev
From: Matteo Croce <mcroce@redhat.com>
Date: Tue, 17 Oct 2017 18:48:12 +0200
> In the UDP code there are two leftover error messages with very few meaning.
> Replace them with a more descriptive error message as some users
> reported them as "strange network error".
Please repost with a proper signoff.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] udp: make some messages more descriptive
2017-10-17 16:48 [PATCH] udp: make some messages more descriptive Matteo Croce
2017-10-19 12:17 ` David Miller
@ 2017-10-19 12:22 ` Matteo Croce
1 sibling, 0 replies; 3+ messages in thread
From: Matteo Croce @ 2017-10-19 12:22 UTC (permalink / raw)
To: netdev, David Miller
In the UDP code there are two leftover error messages with very few meaning.
Replace them with a more descriptive error message as some users
reported them as "strange network error".
Signed-off-by: Matteo Croce <mcroce@redhat.com>
---
v2: added proper signed off tag
net/ipv4/udp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index e45177ceb0ee..806b298a3bdd 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -1061,7 +1061,7 @@ int udp_sendmsg(struct sock *sk, struct msghdr *msg, size_t len)
/* ... which is an evident application bug. --ANK */
release_sock(sk);
- net_dbg_ratelimited("cork app bug 2\n");
+ net_dbg_ratelimited("socket already corked\n");
err = -EINVAL;
goto out;
}
@@ -1144,7 +1144,7 @@ int udp_sendpage(struct sock *sk, struct page *page, int offset,
if (unlikely(!up->pending)) {
release_sock(sk);
- net_dbg_ratelimited("udp cork app bug 3\n");
+ net_dbg_ratelimited("cork failed\n");
return -EINVAL;
}
--
2.13.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-19 12:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-17 16:48 [PATCH] udp: make some messages more descriptive Matteo Croce
2017-10-19 12:17 ` David Miller
2017-10-19 12:22 ` [PATCH v2] " Matteo Croce
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).