From: David Miller <davem@davemloft.net>
To: cugyly@163.com
Cc: netdev@vger.kernel.org, Linyu.Yuan@alcatel-sbell.com.cn
Subject: Re: [PATCH net-next v2 2/2] net: add skb_memcpy_to[from]_msg() to optimize skb code
Date: Wed, 18 Oct 2017 12:18:34 +0100 (WEST) [thread overview]
Message-ID: <20171018.121834.1670470800745081134.davem@davemloft.net> (raw)
In-Reply-To: <1508155873-23752-1-git-send-email-cugyly@163.com>
From: yuan linyu <cugyly@163.com>
Date: Mon, 16 Oct 2017 20:11:13 +0800
> From: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
>
> add these two wrappers in skbuff.h which is better named
> than previous and only used for skb.
>
> Signed-off-by: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
Doing the skb_put() inside of the helper function makes code less
intuitive.
If someone is auditing code it's easier to see the skb_put() and
understand what is happening when it's at the call site rather than
buried in some helper.
Sorry, I don't see these changes as an improvement and will not apply
them.
Thank you.
prev parent reply other threads:[~2017-10-18 11:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 12:11 [PATCH net-next v2 2/2] net: add skb_memcpy_to[from]_msg() to optimize skb code yuan linyu
2017-10-18 11:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018.121834.1670470800745081134.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Linyu.Yuan@alcatel-sbell.com.cn \
--cc=cugyly@163.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox