From: David Miller <davem@davemloft.net>
To: vivien.didelot@savoirfairelinux.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com, f.fainelli@gmail.com,
andrew@lunn.ch
Subject: Re: [PATCH net-next v2 0/7] net: dsa: master and slave helpers
Date: Wed, 18 Oct 2017 12:24:53 +0100 (WEST) [thread overview]
Message-ID: <20171018.122453.2063474159565652979.davem@davemloft.net> (raw)
In-Reply-To: <20171016151219.22023-1-vivien.didelot@savoirfairelinux.com>
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Mon, 16 Oct 2017 11:12:12 -0400
> This patch series adds a few helpers to DSA core for clarity and
> readability but brings no functional changes.
>
> A dsa_slave_notify helper calls the DSA notifiers when (un)registering a
> slave device.
>
> Most of the DSA slave code only needs to access the dsa_port structure,
> not the dsa_slave_priv (which only contains a few PHY-specific members).
> Thus a dsa_slave_to_port helper returns a dsa_port structure of a slave
> device.
>
> A dsa_slave_to_master returns the master device of a slave device.
>
> After that the netdev member of the dsa_port structure is split into two
> explicit master and slave members to avoid confusion, and a dsa_to_port
> helper is added for switch drivers to get a const reference to a port.
>
> Changes in v2:
> - prefer dsa_slave_to_master instead of dsa_slave_get_master
> - rename dsa_master_get_slave to dsa_master_find_slave
> - pack master and slave net devices into an anonymous union
> - add dsa_to_port public helper for switch drivers
> - add Reviewed-by tags from Florian
Series applied.
prev parent reply other threads:[~2017-10-18 11:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 15:12 [PATCH net-next v2 0/7] net: dsa: master and slave helpers Vivien Didelot
2017-10-16 15:12 ` [PATCH net-next v2 1/7] net: dsa: use port's cpu_dp when creating a slave Vivien Didelot
2017-10-16 15:12 ` [PATCH net-next v2 2/7] net: dsa: add slave notify helper Vivien Didelot
2017-10-16 15:12 ` [PATCH net-next v2 3/7] net: dsa: add slave to port helper Vivien Didelot
2017-10-16 15:12 ` [PATCH net-next v2 4/7] net: dsa: add slave to master helper Vivien Didelot
2017-10-16 15:12 ` [PATCH net-next v2 5/7] net: dsa: rename dsa_master_get_slave Vivien Didelot
2017-10-16 15:12 ` [PATCH net-next v2 6/7] net: dsa: split dsa_port's netdev member Vivien Didelot
2017-10-16 15:12 ` [PATCH net-next v2 7/7] net: dsa: add dsa_to_port helper Vivien Didelot
2017-10-18 11:24 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018.122453.2063474159565652979.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox