From: David Miller <davem@davemloft.net>
To: kilobyte@angband.pl
Cc: khc@pm.waw.pl, netdev@vger.kernel.org
Subject: Re: [PATCH] wanxl: use m68k-linux-gnu-as if available
Date: Wed, 18 Oct 2017 13:07:21 +0100 (WEST) [thread overview]
Message-ID: <20171018.130721.1208428223967129203.davem@davemloft.net> (raw)
In-Reply-To: <20171018113326.2rkpe7wrlzihwdyb@angband.pl>
From: Adam Borowski <kilobyte@angband.pl>
Date: Wed, 18 Oct 2017 13:33:26 +0200
> On Wed, Oct 18, 2017 at 12:08:12PM +0100, David Miller wrote:
>> From: Adam Borowski <kilobyte@angband.pl>
>> Date: Fri, 13 Oct 2017 01:24:34 +0200
>>
>> > This fixes build failure on Debian based systems: GNU as is the only m68k
>> > assembler available in the archive (package binutils-m68k-linux-gnu).
>> >
>> > Signed-off-by: Adam Borowski <kilobyte@angband.pl>
>>
>> The Kconfig help text for the config option controlling the build
>> firmware is extremely clear what the requirements are for enabling
>> that option.
>>
>> And that is: "It requires as68k, ld68k and hexdump programs."
>
> Yeah, but as far as I know, as68k is a name of "GNU as"; Debian calls the
> same m68k-linux-gnu-as (and in general, $(GNU_TRIPLET)-as for all usual
> cross toolchains shipped). And as Debian derivatives make the majority of
> distro installs these days, supporting its naming scheme would be
> convenient.
>
> Or, if you believe no one should try to build this firmware from source,
> it might be better to annotate it to be excluded from randconfig builds.
We don't even know if whatever "as68k" is would be the same thing
as GNU as and generate the same binaries.
If you really must, somehow make sure the proper tools are available
at build or Kconfig time.
next prev parent reply other threads:[~2017-10-18 12:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 23:24 [PATCH] wanxl: use m68k-linux-gnu-as if available Adam Borowski
2017-10-18 11:08 ` David Miller
2017-10-18 11:33 ` Adam Borowski
2017-10-18 12:07 ` David Miller [this message]
2017-10-19 17:25 ` Krzysztof Halasa
2017-10-19 19:31 ` Adam Borowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018.130721.1208428223967129203.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=khc@pm.waw.pl \
--cc=kilobyte@angband.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox