From: David Miller <davem@davemloft.net>
To: madalin.bucur@nxp.com
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com, andrew@lunn.ch,
vivien.didelot@savoirfairelinux.com, junote@outlook.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/6] adapt DPAA drivers for DSA
Date: Wed, 18 Oct 2017 13:45:04 +0100 (WEST) [thread overview]
Message-ID: <20171018.134504.1506752039585315800.davem@davemloft.net> (raw)
In-Reply-To: <1508178970-28945-1-git-send-email-madalin.bucur@nxp.com>
From: Madalin Bucur <madalin.bucur@nxp.com>
Date: Mon, 16 Oct 2017 21:36:04 +0300
> Junote Cai reported that he was not able to get a DSA setup involving the
> DPAA/FMAN driver to work and narrowed it down to of_find_net_device_by_node()
> call in DSA setup. The initial attempt to fix this by adding of_node to the
> platform device results in a second, failed, probing of the FMan MAC driver
> against the new platform device created for the DPAA Ethernet driver.
> Solve these issues by removing the of_node pointer from the platform device
> and changing the net_dev dev to the of_device dev to ensure the DSA init
> will be able to find the DPAA net_dev using of_find_net_device_by_node().
> Several changes were required to enable this solution: refactoring the
> adjust_link (also resulted in lesser, cleaner code) and renaming the fman
> kernel modules to keep the legacy udev rules happy.
>
> Changes in v2:
>
> - fix issue on error path in "dpaa_eth: change device used" patch
> - cleanup the dpaa_eth_probe() error paths
>
> Changes in v3:
>
> - remove obsolete comment in moved code
> - add explanation for module rename
Series applied.
prev parent reply other threads:[~2017-10-18 12:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 18:36 [PATCH v3 0/6] adapt DPAA drivers for DSA Madalin Bucur
2017-10-16 18:36 ` [PATCH v3 1/6] fsl/fman: remove of_node Madalin Bucur
2017-10-16 18:36 ` [PATCH v3 2/6] dpaa_eth: move of_phy_connect() to the eth driver Madalin Bucur
2017-10-16 18:36 ` [PATCH v3 3/6] dpaa_eth: change device used Madalin Bucur
2017-10-16 18:36 ` [PATCH v3 4/6] dpaa_eth: cleanup dpaa_eth_probe() error paths Madalin Bucur
2017-10-16 18:36 ` [PATCH v3 5/6] fsl/fman: add dpaa in module names Madalin Bucur
2017-10-16 18:36 ` [PATCH v3 6/6] dpaa_eth: remove obsolete comment Madalin Bucur
2017-10-18 12:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018.134504.1506752039585315800.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=junote@outlook.com \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).