From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: netdev <netdev@vger.kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: using verifier to ensure a BPF program uses certain metadata?
Date: Wed, 18 Oct 2017 10:42:55 -0700 [thread overview]
Message-ID: <20171018174253.sozuxdyfusixc5sx@ast-mbp> (raw)
In-Reply-To: <1508309791.2674.1.camel@sipsolutions.net>
On Wed, Oct 18, 2017 at 08:56:31AM +0200, Johannes Berg wrote:
> > > Now, I realize that people could trivially just work around this in
> > > their program if they wanted, but I think most will take the
> > > reminder
> > > and just implement
> > >
> > > if (ctx->is_data_ethernet)
> > > return DROP_FRAME;
> > >
> > > instead, since mostly data frames will not be very relevant to
> > > them.
> > >
> > > What do you think?
> >
> > sounds fine and considering new verifier ops after Jakub refactoring
> > a check that is_data_ethernet was accessed would fit nicely.
> > Without void** hack.
>
> Ok, thanks! I'll have to check what Jakub is doing there, do you have a
> pointer to that refactoring?
something similar to
commit 4f9218aaf8a4 ("bpf: move knowledge about post-translation offsets out of verifier")
prev parent reply other threads:[~2017-10-18 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 7:38 using verifier to ensure a BPF program uses certain metadata? Johannes Berg
2017-10-17 22:58 ` Alexei Starovoitov
2017-10-18 6:56 ` Johannes Berg
2017-10-18 17:42 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018174253.sozuxdyfusixc5sx@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox