From: Felix Manlunas <felix.manlunas@cavium.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: Derek Chickles <derek.chickles@caviumnetworks.com>,
Satanand Burla <satananda.burla@caviumnetworks.com>,
Felix Manlunas <felix.manlunas@caviumnetworks.com>,
Raghu Vatsavayi <raghu.vatsavayi@caviumnetworks.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] liquidio: mark expected switch fall-through in octeon_destroy_resources
Date: Wed, 18 Oct 2017 10:53:57 -0700 [thread overview]
Message-ID: <20171018175357.GA14232@felix-thinkpad.cavium.com> (raw)
In-Reply-To: <20171017190145.GA17015@embeddedor.com>
On Tue, Oct 17, 2017 at 02:01:45PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> This code was tested by compilation only (GCC 7.2.0 was used).
> Please, verify if the actual intention of the code is to fall through.
>
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c
> index e4a112c..4c3b568 100644
> --- a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c
> +++ b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c
> @@ -747,7 +747,7 @@ static void octeon_destroy_resources(struct octeon_device *oct)
>
> if (lio_wait_for_oq_pkts(oct))
> dev_err(&oct->pci_dev->dev, "OQ had pending packets\n");
> -
> + /* fall through */
> case OCT_DEV_INTR_SET_DONE:
> /* Disable interrupts */
> oct->fn_list.disable_interrupt(oct, OCTEON_ALL_INTR);
> --
> 2.7.4
>
Acked-by: Felix Manlunas <felix.manlunas@cavium.com>
next prev parent reply other threads:[~2017-10-18 17:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 18:59 [PATCH 1/2] liquidio: remove unnecessary NULL check before kfree in delete_glists Gustavo A. R. Silva
2017-10-17 19:01 ` [PATCH 2/2] liquidio: mark expected switch fall-through in octeon_destroy_resources Gustavo A. R. Silva
2017-10-18 17:53 ` Felix Manlunas [this message]
2017-10-19 12:28 ` David Miller
2017-10-18 17:47 ` [PATCH 1/2] liquidio: remove unnecessary NULL check before kfree in delete_glists Felix Manlunas
2017-10-19 12:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018175357.GA14232@felix-thinkpad.cavium.com \
--to=felix.manlunas@cavium.com \
--cc=derek.chickles@caviumnetworks.com \
--cc=felix.manlunas@caviumnetworks.com \
--cc=garsilva@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=raghu.vatsavayi@caviumnetworks.com \
--cc=satananda.burla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).