* [PATCH] dql: make dql_init return void
@ 2017-10-18 0:16 Stephen Hemminger
2017-10-18 12:15 ` Hiroaki SHIMODA
2017-10-19 12:34 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2017-10-18 0:16 UTC (permalink / raw)
To: Tom Herbert, Hiroaki SHIMODA, davem; +Cc: netdev, Stephen Hemminger
dql_init always returned 0, and the only place that uses it
in network core code didn't care about the return value anyway.
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
include/linux/dynamic_queue_limits.h | 2 +-
lib/dynamic_queue_limits.c | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/include/linux/dynamic_queue_limits.h b/include/linux/dynamic_queue_limits.h
index a4be70398ce1..f69f98541953 100644
--- a/include/linux/dynamic_queue_limits.h
+++ b/include/linux/dynamic_queue_limits.h
@@ -98,7 +98,7 @@ void dql_completed(struct dql *dql, unsigned int count);
void dql_reset(struct dql *dql);
/* Initialize dql state */
-int dql_init(struct dql *dql, unsigned hold_time);
+void dql_init(struct dql *dql, unsigned int hold_time);
#endif /* _KERNEL_ */
diff --git a/lib/dynamic_queue_limits.c b/lib/dynamic_queue_limits.c
index f346715e2255..dbe61c4c2a97 100644
--- a/lib/dynamic_queue_limits.c
+++ b/lib/dynamic_queue_limits.c
@@ -127,12 +127,11 @@ void dql_reset(struct dql *dql)
}
EXPORT_SYMBOL(dql_reset);
-int dql_init(struct dql *dql, unsigned hold_time)
+void dql_init(struct dql *dql, unsigned int hold_time)
{
dql->max_limit = DQL_MAX_LIMIT;
dql->min_limit = 0;
dql->slack_hold_time = hold_time;
dql_reset(dql);
- return 0;
}
EXPORT_SYMBOL(dql_init);
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dql: make dql_init return void
2017-10-18 0:16 [PATCH] dql: make dql_init return void Stephen Hemminger
@ 2017-10-18 12:15 ` Hiroaki SHIMODA
2017-10-19 12:34 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Hiroaki SHIMODA @ 2017-10-18 12:15 UTC (permalink / raw)
To: stephen; +Cc: tom, davem, netdev, sthemmin
On Tue, 17 Oct 2017 17:16:52 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> dql_init always returned 0, and the only place that uses it
> in network core code didn't care about the return value anyway.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Acked-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dql: make dql_init return void
2017-10-18 0:16 [PATCH] dql: make dql_init return void Stephen Hemminger
2017-10-18 12:15 ` Hiroaki SHIMODA
@ 2017-10-19 12:34 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-10-19 12:34 UTC (permalink / raw)
To: stephen; +Cc: tom, shimoda.hiroaki, netdev, sthemmin
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Tue, 17 Oct 2017 17:16:52 -0700
> dql_init always returned 0, and the only place that uses it
> in network core code didn't care about the return value anyway.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-19 12:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-18 0:16 [PATCH] dql: make dql_init return void Stephen Hemminger
2017-10-18 12:15 ` Hiroaki SHIMODA
2017-10-19 12:34 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).