From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinicius Costa Gomes Subject: [next-queue PATCH] net/sched/sch_cbs: Fix compilation on 32bit architectures Date: Wed, 18 Oct 2017 15:47:03 -0700 Message-ID: <20171018224703.15454-1-vinicius.gomes@intel.com> Cc: Vinicius Costa Gomes , jeffrey.t.kirsher@intel.com, jesus.sanchez-palencia@intel.com To: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org Return-path: Received: from mga02.intel.com ([134.134.136.20]:40554 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750932AbdJRWrb (ORCPT ); Wed, 18 Oct 2017 18:47:31 -0400 Sender: netdev-owner@vger.kernel.org List-ID: There was still a couple of divisions of 64bit quantities happening, which can fail to compile if there aren't instructions to handle that kind of division. It will fail with a message like this: ERROR: "__aeabi_ldivmod" [net/sched/sch_cbs.ko] undefined! Signed-off-by: Vinicius Costa Gomes --- net/sched/sch_cbs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/sch_cbs.c b/net/sched/sch_cbs.c index cae021c642e5..bdb533b7fb8c 100644 --- a/net/sched/sch_cbs.c +++ b/net/sched/sch_cbs.c @@ -331,8 +331,8 @@ static int cbs_dump(struct Qdisc *sch, struct sk_buff *skb) opt.hicredit = q->hicredit; opt.locredit = q->locredit; - opt.sendslope = q->sendslope / BYTES_PER_KBIT; - opt.idleslope = q->idleslope / BYTES_PER_KBIT; + opt.sendslope = div64_s64(q->sendslope, BYTES_PER_KBIT); + opt.idleslope = div64_s64(q->idleslope, BYTES_PER_KBIT); opt.offload = q->offload; if (nla_put(skb, TCA_CBS_PARMS, sizeof(opt), &opt)) -- 2.14.2