From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [patch net-next 01/20] net: sched: add block bind/unbind notif. and extended block_get/put Date: Thu, 19 Oct 2017 13:23:11 +0100 (WEST) Message-ID: <20171019.132311.905310714904196268.davem@davemloft.net> References: <20171017200615.4530-1-jiri@resnulli.us> <20171017200615.4530-2-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, jeffrey.t.kirsher@intel.com, saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, ast@kernel.org, daniel@iogearbox.net, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, alexander.h.duyck@intel.com To: jiri@resnulli.us Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:49006 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751579AbdJSMXc (ORCPT ); Thu, 19 Oct 2017 08:23:32 -0400 In-Reply-To: <20171017200615.4530-2-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: From: Jiri Pirko Date: Tue, 17 Oct 2017 22:05:56 +0200 > From: Jiri Pirko > > Introduce new type of ndo_setup_tc message to propage binding/unbinding > of a block to driver. Call this ndo whenever qdisc gets/puts a block. > Alongside with this, there's need to propagate binder type from qdisc > code down to the notifier. So introduce extended variants of > block_get/put in order to pass this info. > > Signed-off-by: Jiri Pirko > --- > include/linux/netdevice.h | 1 + > include/net/pkt_cls.h | 40 +++++++++++++++++++++++++++++++++ > net/sched/cls_api.c | 56 ++++++++++++++++++++++++++++++++++++++++++++--- > 3 files changed, 94 insertions(+), 3 deletions(-) > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index 31bb301..062a4f5 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -771,6 +771,7 @@ typedef u16 (*select_queue_fallback_t)(struct net_device *dev, > > enum tc_setup_type { > TC_SETUP_MQPRIO, > + TC_SETUP_BLOCK, > TC_SETUP_CLSU32, > TC_SETUP_CLSFLOWER, > TC_SETUP_CLSMATCHALL, Like David I think you should add this to the end of the list. If you don't "think" about backporting issues when doing upstream work, you're not "think"ing about some of the people who end up using your code. Thank you.