From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, edumazet@google.com
Subject: Re: [PATCH net] dccp/tcp: fix ireq->opt races
Date: Thu, 19 Oct 2017 13:31:38 +0100 (WEST) [thread overview]
Message-ID: <20171019.133138.1755187507720163652.davem@davemloft.net> (raw)
In-Reply-To: <1508269526.31614.113.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 17 Oct 2017 12:45:26 -0700
> syzkaller found another bug in DCCP/TCP stacks [1]
>
> For the reasons explained in commit ce1050089c96 ("tcp/dccp: fix
> ireq->pktopts race"), we need to make sure we do not access
> ireq->opt unless we own the request sock.
This doesn't apply to 'net'.
[davem@kkuri net]$ git am --signoff v2-net-dccp-tcp-fix-ireq--opt-races.patch
Applying: dccp/tcp: fix ireq->opt races
error: patch failed: include/net/inet_sock.h:96
error: include/net/inet_sock.h: patch does not apply
error: patch failed: net/dccp/ipv4.c:414
error: net/dccp/ipv4.c: patch does not apply
error: patch failed: net/ipv4/inet_connection_sock.c:540
error: net/ipv4/inet_connection_sock.c: patch does not apply
error: patch failed: net/ipv4/syncookies.c:355
error: net/ipv4/syncookies.c: patch does not apply
error: patch failed: net/ipv4/tcp_input.c:6196
error: net/ipv4/tcp_input.c: patch does not apply
error: patch failed: net/ipv4/tcp_ipv4.c:877
error: net/ipv4/tcp_ipv4.c: patch does not apply
next prev parent reply other threads:[~2017-10-19 12:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 19:45 [PATCH net] dccp/tcp: fix ireq->opt races Eric Dumazet
2017-10-17 19:50 ` Eric Dumazet
2017-10-17 19:53 ` Eric Dumazet
2017-10-17 19:55 ` [PATCH v2 " Eric Dumazet
2017-10-20 16:53 ` [PATCH " kbuild test robot
2017-10-20 17:38 ` Eric Dumazet
2017-10-20 16:53 ` kbuild test robot
2017-10-20 18:34 ` kbuild test robot
2017-10-19 12:31 ` David Miller [this message]
2017-10-19 14:45 ` Eric Dumazet
2017-10-19 22:07 ` David Miller
2017-10-19 22:21 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019.133138.1755187507720163652.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).