From: Steven Rostedt <rostedt@goodmis.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Ingo Molnar <mingo@redhat.com>,
David Ahern <dsa@cumulusnetworks.com>
Subject: Re: [PATCH net-next] ipv6: let trace_fib6_table_lookup() dereference the fib table
Date: Thu, 19 Oct 2017 09:30:25 -0400 [thread overview]
Message-ID: <20171019093025.5a7b9ea2@vmware.local.home> (raw)
In-Reply-To: <48235df8fdf787356070d8baa1ac9816ef5736d4.1508398120.git.pabeni@redhat.com>
On Thu, 19 Oct 2017 09:31:43 +0200
Paolo Abeni <pabeni@redhat.com> wrote:
> The perf traces for ipv6 routing code show a relevant cost around
> trace_fib6_table_lookup(), even if no trace is enabled. This is
> due to the fib6_table de-referencing currently performed by the
> caller.
>
> Let's the tracing code pay this overhead, passing to the trace
> helper the table pointer. This gives small but measurable
> performance improvement under UDP flood.
>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
next prev parent reply other threads:[~2017-10-19 13:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 7:31 [PATCH net-next] ipv6: let trace_fib6_table_lookup() dereference the fib table Paolo Abeni
2017-10-19 13:30 ` Steven Rostedt [this message]
2017-10-19 15:38 ` David Ahern
2017-10-19 17:26 ` Martin KaFai Lau
2017-10-21 1:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019093025.5a7b9ea2@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).