From: Richard Cochran <richardcochran@gmail.com>
To: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>
Cc: Vinicius Costa Gomes <vinicius.gomes@intel.com>,
netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us,
intel-wired-lan@lists.osuosl.org, andre.guedes@intel.com,
ivan.briano@intel.com, boon.leong.ong@intel.com,
Levi Pearson <levipearson@gmail.com>,
Henrik Austad <henrik@austad.us>
Subject: Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers
Date: Thu, 19 Oct 2017 13:39:49 -0700 [thread overview]
Message-ID: <20171019203949.pyv44i5sy6lnuavh@localhost> (raw)
In-Reply-To: <62f3eae4-bf6a-1475-936f-5011c9ff381e@intel.com>
On Wed, Oct 18, 2017 at 03:37:35PM -0700, Jesus Sanchez-Palencia wrote:
> I also did some tests with when you don't set valid launch times, but here using
> your idea from above, so with the driver calculating a valid launch time (i.e.
> current NIC time + X ns, varying X across tests) for packets that didn't have it
> set by the user, and I wasn't too happy with its reliability. It could
> definitely be improved, but it has left me wondering: instead, what about
> documenting that if you enable TXTIME, then you *must* provide a valid Launch
> time for all packets on traffic classes that are affected?
If txtime is enabled, then CBS is pointless because the txtime already
specifies the bandwidth implicitly.
The problem is when one program uses txtime and another uses CBS, then
the CBS user will experience really wrong performance.
Thanks,
Richard
next prev parent reply other threads:[~2017-10-19 20:39 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 1:26 [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers Vinicius Costa Gomes
2017-09-01 1:26 ` [RFC net-next 1/5] net/sched: Introduce the user API for the CBS shaper Vinicius Costa Gomes
2017-09-01 1:26 ` [RFC net-next 2/5] net/sched: Introduce Credit Based Shaper (CBS) qdisc Vinicius Costa Gomes
2017-09-08 13:43 ` Henrik Austad
2017-09-14 0:39 ` Vinicius Costa Gomes
2017-09-01 1:26 ` [RFC net-next 3/5] igb: Add support for CBS offload Vinicius Costa Gomes
2017-09-01 1:26 ` [RFC net-next 4/5] sample: Add TSN Talker and Listener examples Vinicius Costa Gomes
2017-09-01 1:26 ` [RFC net-next 5/5] samples/tsn: Add script for calculating CBS config Vinicius Costa Gomes
2017-09-01 13:03 ` [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers Richard Cochran
2017-09-01 16:12 ` Jesus Sanchez-Palencia
2017-09-01 16:53 ` Richard Cochran
2017-09-05 7:20 ` Richard Cochran
2017-09-07 5:34 ` Henrik Austad
2017-09-07 12:40 ` Richard Cochran
2017-09-07 15:27 ` Henrik Austad
2017-09-07 15:53 ` Richard Cochran
2017-09-07 16:18 ` Henrik Austad
2017-09-07 21:51 ` Guedes, Andre
2017-09-07 19:58 ` Guedes, Andre
2017-09-08 6:06 ` Henrik Austad
2017-09-08 1:29 ` Vinicius Costa Gomes
2017-09-12 4:56 ` Richard Cochran
2017-09-18 8:02 ` Richard Cochran
2017-09-18 11:46 ` Henrik Austad
2017-09-18 23:06 ` Vinicius Costa Gomes
2017-09-19 5:22 ` Richard Cochran
2017-09-19 13:14 ` Henrik Austad
2017-09-20 0:19 ` Vinicius Costa Gomes
2017-09-20 5:25 ` Richard Cochran
2017-10-18 22:37 ` Jesus Sanchez-Palencia
2017-10-19 20:39 ` Richard Cochran [this message]
2017-10-23 17:18 ` Jesus Sanchez-Palencia
2017-09-20 5:58 ` Richard Cochran
2017-09-18 8:12 ` Richard Cochran
2017-09-20 5:17 ` TSN Scorecard, was " levipearson
2017-09-20 5:49 ` Richard Cochran
2017-09-20 21:29 ` Jesus Sanchez-Palencia
2017-09-20 1:59 ` levipearson
2017-09-20 5:56 ` Richard Cochran
-- strict thread matches above, loose matches on Subject: below --
2017-09-29 20:44 Rodney Cummings
2017-10-02 18:45 ` Levi Pearson
2017-10-02 19:40 ` Rodney Cummings
2017-10-02 21:48 ` Levi Pearson
2017-10-02 22:52 ` Rodney Cummings
2017-10-02 23:06 ` Guedes, Andre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019203949.pyv44i5sy6lnuavh@localhost \
--to=richardcochran@gmail.com \
--cc=andre.guedes@intel.com \
--cc=boon.leong.ong@intel.com \
--cc=henrik@austad.us \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=ivan.briano@intel.com \
--cc=jesus.sanchez-palencia@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=levipearson@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vinicius.gomes@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).