From: "Yang, Yi" <yi.y.yang@intel.com>
To: Jiri Benc <jbenc@redhat.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"dev@openvswitch.org" <dev@openvswitch.org>,
"e@erig.me" <e@erig.me>, "pshelar@ovn.org" <pshelar@ovn.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH net-next v12] openvswitch: enable NSH support
Date: Fri, 20 Oct 2017 05:53:12 +0800 [thread overview]
Message-ID: <20171019215312.GA91385@cran64.bj.intel.com> (raw)
In-Reply-To: <20171019154118.16d906e0@griffin>
On Thu, Oct 19, 2017 at 03:41:18PM +0200, Jiri Benc wrote:
> On Thu, 19 Oct 2017 21:12:15 +0800, Yang, Yi wrote:
> > flow_key in set_nsh is got from netlink message which is set by
> > commit_nsh in user space, here is code.
>
> Isn't this the 'key' local variable that you're talking about, while I'm
> referring to the 'flow_key' parameter?
Oh, my mistake, but it is possible not to polulate nsh key in flow_key
for push_nsh then set, as Jan and I explained before, we don't
recirculate the packet after push_nsh for performance, so parse function
isn't called for NSH header, mdtype can't be gotten from flow_key yet.
Only one case is true, i.e. an ingress NSH packet is parsed then set by
changing si and ttl.
For push_nsh, my typical use scinario is push_nsh then set then output
to vxlangpe port.
>
> Jiri
next prev parent reply other threads:[~2017-10-19 22:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 13:53 [PATCH net-next v12] openvswitch: enable NSH support Yi Yang
2017-10-18 21:19 ` Jiri Benc
2017-10-19 11:40 ` Yang, Yi
2017-10-19 12:43 ` Jiri Benc
2017-10-19 13:12 ` Yang, Yi
[not found] ` <20171019131215.GA84551-re2EX8HDrk21gSHoDXDV2kEOCMrvLtNR@public.gmane.org>
2017-10-19 13:41 ` Jiri Benc
2017-10-19 21:53 ` Yang, Yi [this message]
2017-10-20 8:05 ` Jiri Benc
2017-10-20 11:34 ` Yang, Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019215312.GA91385@cran64.bj.intel.com \
--to=yi.y.yang@intel.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=e@erig.me \
--cc=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).