From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v3 net] dccp/tcp: fix ireq->opt races Date: Fri, 20 Oct 2017 07:18:31 +0100 (WEST) Message-ID: <20171020.071831.180922551241959965.davem@davemloft.net> References: <1508451889.30291.4.camel@edumazet-glaptop3.roam.corp.google.com> <20171020.070458.2242397039979446788.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 Content-Transfer-Encoding: base64 Cc: netdev@vger.kernel.org To: eric.dumazet@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:33084 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751093AbdJTGSe (ORCPT ); Fri, 20 Oct 2017 02:18:34 -0400 In-Reply-To: <20171020.070458.2242397039979446788.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: RnJvbTogRGF2aWQgTWlsbGVyIDxkYXZlbUBkYXZlbWxvZnQubmV0Pg0KRGF0ZTogRnJpLCAyMCBP Y3QgMjAxNyAwNzowNDo1OCArMDEwMCAoV0VTVCkNCg0KPiBNdWNoIGJldHRlciwgYXBwbGllZCBh bmQgcXVldWVkIHVwIGZvciAtc3RhYmxlLg0KDQpJIHRha2UgdGhhdCBiYWNrLg0KDQpQbGVhc2Ug YnVpbGQgdGVzdCB5b3VyIGNoYW5nZXMgbW9yZSB0aG9yb3VnaGx5Lg0KDQpJbiBmaWxlIGluY2x1 ZGVkIGZyb20gLi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9hdG9taWMuaDo3OjAsDQogICAgICAgICAg ICAgICAgIGZyb20gLi9pbmNsdWRlL2xpbnV4L2F0b21pYy5oOjQsDQogICAgICAgICAgICAgICAg IGZyb20gLi9pbmNsdWRlL2xpbnV4L3JjdXBkYXRlLmg6MzgsDQogICAgICAgICAgICAgICAgIGZy b20gbmV0L2lwdjQvY2lwc29faXB2NC5jOjQwOg0KbmV0L2lwdjQvY2lwc29faXB2NC5jOiBJbiBm dW5jdGlvbiChY2lwc29fdjRfcmVxX3NldGF0dHKiOg0KbmV0L2lwdjQvY2lwc29faXB2NC5jOjE5 NTQ6MjI6IGVycm9yOiChc3RydWN0IGluZXRfcmVxdWVzdF9zb2NroiBoYXMgbm8gbWVtYmVyIG5h bWVkIKFvcHSiDQogIG9wdCA9IHhjaGcoJnJlcV9pbmV0LT5vcHQsIG9wdCk7DQogICAgICAgICAg ICAgICAgICAgICAgXg0KLi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9jbXB4Y2hnLmg6NDM6MjQ6IG5v dGU6IGluIGRlZmluaXRpb24gb2YgbWFjcm8goV9feGNoZ19vcKINCiAgICAgICAgICBfX3R5cGVv Zl9fICgqKHB0cikpIF9fcmV0ID0gKGFyZyk7ICAgXA0KICAgICAgICAgICAgICAgICAgICAgICAg Xn5+DQpuZXQvaXB2NC9jaXBzb19pcHY0LmM6MTk1NDo4OiBub3RlOiBpbiBleHBhbnNpb24gb2Yg bWFjcm8goXhjaGeiDQogIG9wdCA9IHhjaGcoJnJlcV9pbmV0LT5vcHQsIG9wdCk7DQogICAgICAg IF5+fn4NCi4vYXJjaC94ODYvaW5jbHVkZS9hc20vY21weGNoZy5oOjQzOjM4OiB3YXJuaW5nOiBp bml0aWFsaXphdGlvbiBtYWtlcyBpbnRlZ2VyIGZyb20gcG9pbnRlciB3aXRob3V0IGEgY2FzdCBb LVdpbnQtY29udmVyc2lvbl0NCiAgICAgICAgICBfX3R5cGVvZl9fICgqKHB0cikpIF9fcmV0ID0g KGFyZyk7ICAgXA0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBeDQouL2Fy Y2gveDg2L2luY2x1ZGUvYXNtL2NtcHhjaGcuaDo3NzoyMjogbm90ZTogaW4gZXhwYW5zaW9uIG9m IG1hY3JvIKFfX3hjaGdfb3CiDQogI2RlZmluZSB4Y2hnKHB0ciwgdikgX194Y2hnX29wKChwdHIp LCAodiksIHhjaGcsICIiKQ0KICAgICAgICAgICAgICAgICAgICAgIF5+fn5+fn5+fg0KbmV0L2lw djQvY2lwc29faXB2NC5jOjE5NTQ6ODogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIKF4Y2hn og0KICBvcHQgPSB4Y2hnKCZyZXFfaW5ldC0+b3B0LCBvcHQpOw0KICAgICAgICBefn5+DQpuZXQv aXB2NC9jaXBzb19pcHY0LmM6MTk1NDoyMjogZXJyb3I6IKFzdHJ1Y3QgaW5ldF9yZXF1ZXN0X3Nv Y2uiIGhhcyBubyBtZW1iZXIgbmFtZWQgoW9wdKINCiAgb3B0ID0geGNoZygmcmVxX2luZXQtPm9w dCwgb3B0KTsNCiAgICAgICAgICAgICAgICAgICAgICBeDQouL2FyY2gveDg2L2luY2x1ZGUvYXNt L2NtcHhjaGcuaDo0NDoyMDogbm90ZTogaW4gZGVmaW5pdGlvbiBvZiBtYWNybyChX194Y2hnX29w og0KICAgc3dpdGNoIChzaXplb2YoKihwdHIpKSkgeyAgICBcDQogICAgICAgICAgICAgICAgICAg IF5+fg0KbmV0L2lwdjQvY2lwc29faXB2NC5jOjE5NTQ6ODogbm90ZTogaW4gZXhwYW5zaW9uIG9m IG1hY3JvIKF4Y2hnog0KICBvcHQgPSB4Y2hnKCZyZXFfaW5ldC0+b3B0LCBvcHQpOw0KICAgICAg ICBefn5+DQpuZXQvaXB2NC9jaXBzb19pcHY0LmM6MTk1NDoyMjogZXJyb3I6IKFzdHJ1Y3QgaW5l dF9yZXF1ZXN0X3NvY2uiIGhhcyBubyBtZW1iZXIgbmFtZWQgoW9wdKINCiAgb3B0ID0geGNoZygm cmVxX2luZXQtPm9wdCwgb3B0KTsNCiAgICAgICAgICAgICAgICAgICAgICBeDQouL2FyY2gveDg2 L2luY2x1ZGUvYXNtL2NtcHhjaGcuaDo0NzozNTogbm90ZTogaW4gZGVmaW5pdGlvbiBvZiBtYWNy byChX194Y2hnX29wog0KICAgICAgICAgICA6ICIrcSIgKF9fcmV0KSwgIittIiAoKihwdHIpKSBc DQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF5+fg0KbmV0L2lwdjQvY2lwc29f aXB2NC5jOjE5NTQ6ODogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIKF4Y2hnog0KICBvcHQg PSB4Y2hnKCZyZXFfaW5ldC0+b3B0LCBvcHQpOw0KICAgICAgICBefn5+DQpuZXQvaXB2NC9jaXBz b19pcHY0LmM6MTk1NDoyMjogZXJyb3I6IKFzdHJ1Y3QgaW5ldF9yZXF1ZXN0X3NvY2uiIGhhcyBu byBtZW1iZXIgbmFtZWQgoW9wdKINCiAgb3B0ID0geGNoZygmcmVxX2luZXQtPm9wdCwgb3B0KTsN CiAgICAgICAgICAgICAgICAgICAgICBeDQouL2FyY2gveDg2L2luY2x1ZGUvYXNtL2NtcHhjaGcu aDo1MjozNTogbm90ZTogaW4gZGVmaW5pdGlvbiBvZiBtYWNybyChX194Y2hnX29wog0KICAgICAg ICAgICA6ICIrciIgKF9fcmV0KSwgIittIiAoKihwdHIpKSBcDQogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIF5+fg0KbmV0L2lwdjQvY2lwc29faXB2NC5jOjE5NTQ6ODogbm90ZTog aW4gZXhwYW5zaW9uIG9mIG1hY3JvIKF4Y2hnog0KICBvcHQgPSB4Y2hnKCZyZXFfaW5ldC0+b3B0 LCBvcHQpOw0KICAgICAgICBefn5+DQpuZXQvaXB2NC9jaXBzb19pcHY0LmM6MTk1NDoyMjogZXJy b3I6IKFzdHJ1Y3QgaW5ldF9yZXF1ZXN0X3NvY2uiIGhhcyBubyBtZW1iZXIgbmFtZWQgoW9wdKIN CiAgb3B0ID0geGNoZygmcmVxX2luZXQtPm9wdCwgb3B0KTsNCiAgICAgICAgICAgICAgICAgICAg ICBeDQouL2FyY2gveDg2L2luY2x1ZGUvYXNtL2NtcHhjaGcuaDo1NzozNTogbm90ZTogaW4gZGVm aW5pdGlvbiBvZiBtYWNybyChX194Y2hnX29wog0KICAgICAgICAgICA6ICIrciIgKF9fcmV0KSwg IittIiAoKihwdHIpKSBcDQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF5+fg0K bmV0L2lwdjQvY2lwc29faXB2NC5jOjE5NTQ6ODogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3Jv IKF4Y2hnog0KICBvcHQgPSB4Y2hnKCZyZXFfaW5ldC0+b3B0LCBvcHQpOw0KICAgICAgICBefn5+ DQpuZXQvaXB2NC9jaXBzb19pcHY0LmM6MTk1NDoyMjogZXJyb3I6IKFzdHJ1Y3QgaW5ldF9yZXF1 ZXN0X3NvY2uiIGhhcyBubyBtZW1iZXIgbmFtZWQgoW9wdKINCiAgb3B0ID0geGNoZygmcmVxX2lu ZXQtPm9wdCwgb3B0KTsNCiAgICAgICAgICAgICAgICAgICAgICBeDQouL2FyY2gveDg2L2luY2x1 ZGUvYXNtL2NtcHhjaGcuaDo2MjozNTogbm90ZTogaW4gZGVmaW5pdGlvbiBvZiBtYWNybyChX194 Y2hnX29wog0KICAgICAgICAgICA6ICIrciIgKF9fcmV0KSwgIittIiAoKihwdHIpKSBcDQogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF5+fg0KbmV0L2lwdjQvY2lwc29faXB2NC5j OjE5NTQ6ODogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIKF4Y2hnog0KICBvcHQgPSB4Y2hn KCZyZXFfaW5ldC0+b3B0LCBvcHQpOw0KICAgICAgICBefn5+DQpuZXQvaXB2NC9jaXBzb19pcHY0 LmM6MTk1NDo2OiB3YXJuaW5nOiBhc3NpZ25tZW50IG1ha2VzIHBvaW50ZXIgZnJvbSBpbnRlZ2Vy IHdpdGhvdXQgYSBjYXN0IFstV2ludC1jb252ZXJzaW9uXQ0KICBvcHQgPSB4Y2hnKCZyZXFfaW5l dC0+b3B0LCBvcHQpOw0KICAgICAgXg0KbmV0L2lwdjQvY2lwc29faXB2NC5jOiBJbiBmdW5jdGlv biChY2lwc29fdjRfcmVxX2RlbGF0dHKiOg0KbmV0L2lwdjQvY2lwc29faXB2NC5jOjIwNzM6MTY6 IGVycm9yOiChc3RydWN0IGluZXRfcmVxdWVzdF9zb2NroiBoYXMgbm8gbWVtYmVyIG5hbWVkIKFv cHSiDQogIG9wdCA9IHJlcV9pbmV0LT5vcHQ7DQogICAgICAgICAgICAgICAgXn4NCm5ldC9pcHY0 L2NpcHNvX2lwdjQuYzoyMDc3OjI3OiBlcnJvcjogoXN0cnVjdCBpbmV0X3JlcXVlc3Rfc29ja6Ig aGFzIG5vIG1lbWJlciBuYW1lZCChb3B0og0KICBjaXBzb192NF9kZWxvcHQoJnJlcV9pbmV0LT5v cHQpOw0KICAgICAgICAgICAgICAgICAgICAgICAgICAgXn4NCnNjcmlwdHMvTWFrZWZpbGUuYnVp bGQ6MzEzOiByZWNpcGUgZm9yIHRhcmdldCAnbmV0L2lwdjQvY2lwc29faXB2NC5vJyBmYWlsZWQN Cm1ha2VbMl06ICoqKiBbbmV0L2lwdjQvY2lwc29faXB2NC5vXSBFcnJvciAxDQptYWtlWzJdOiAq KiogV2FpdGluZyBmb3IgdW5maW5pc2hlZCBqb2JzLi4uLg0Kc2NyaXB0cy9NYWtlZmlsZS5idWls ZDo1NzI6IHJlY2lwZSBmb3IgdGFyZ2V0ICduZXQvaXB2NCcgZmFpbGVkDQptYWtlWzFdOiAqKiog W25ldC9pcHY0XSBFcnJvciAyDQpNYWtlZmlsZToxMDE5OiByZWNpcGUgZm9yIHRhcmdldCAnbmV0 JyBmYWlsZWQNCm1ha2U6ICoqKiBbbmV0XSBFcnJvciAyDQo=