From: David Miller <davem@davemloft.net>
To: dsahern@gmail.com
Cc: netdev@vger.kernel.org, jiri@mellanox.com, idosch@mellanox.com,
kjlx@templeofstupid.com, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH v3 net-next 0/5] mlxsw: spectrum_router: Add extack messages for RIF and VRF overflow
Date: Fri, 20 Oct 2017 13:15:27 +0100 (WEST) [thread overview]
Message-ID: <20171020.131527.985111293556777030.davem@davemloft.net> (raw)
In-Reply-To: <1508345816-25678-1-git-send-email-dsahern@gmail.com>
From: David Ahern <dsahern@gmail.com>
Date: Wed, 18 Oct 2017 09:56:51 -0700
> Currently, exceeding the number of VRF instances or the number of router
> interfaces either fails with a non-intuitive EBUSY:
> $ ip li set swp1s1.6 vrf vrf-1s1-6 up
> RTNETLINK answers: Device or resource busy
>
> or fails silently (IPv6) since the checks are done in a work queue. This
> set adds support for the address validator notifier to spectrum which
> allows ext-ack based messages to be returned on failure.
>
> To make that happen the IPv6 version needs to be converted from atomic
> to blocking (patch 2), and then support for extack needs to be added
> to the notifier (patch 3). Patch 1 reworks the locking in ipv6_add_addr
> to work better in the atomic and non-atomic code paths. Patches 4 and 5
> add the validator notifier to spectrum and then plumb the extack argument
> through spectrum_router.
>
> With this set, VRF overflows fail with:
> $ ip li set swp1s1.6 vrf vrf-1s1-6 up
> Error: spectrum: Exceeded number of supported VRF.
>
> and RIF overflows fail with:
> $ ip addr add dev swp1s2.191 10.12.191.1/24
> Error: spectrum: Exceeded number of supported router interfaces.
Series applied.
prev parent reply other threads:[~2017-10-20 12:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 16:56 [PATCH v3 net-next 0/5] mlxsw: spectrum_router: Add extack messages for RIF and VRF overflow David Ahern
2017-10-18 16:56 ` [PATCH v3 net-next 1/5] ipv6: addrconf: cleanup locking in ipv6_add_addr David Ahern
2017-10-18 16:56 ` [PATCH v3 net-next 2/5] net: ipv6: Make inet6addr_validator a blocking notifier David Ahern
2017-10-18 16:56 ` [PATCH v3 net-next 3/5] net: Add extack to validator_info structs used for address notifier David Ahern
2017-10-18 16:56 ` [PATCH v3 net-next 4/5] mlxsw: spectrum: router: Add support for address validator notifier David Ahern
2017-10-18 16:56 ` [PATCH v3 net-next 5/5] mlxsw: spectrum_router: Add extack message for RIF and VRF overflow David Ahern
2017-10-20 12:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020.131527.985111293556777030.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kjlx@templeofstupid.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).