From: Christoph Hellwig <hch@infradead.org>
To: Kees Cook <keescook@chromium.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Craig Gallek <cgallek@google.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] timer: Provide wrappers safe for use with LOCKDEP
Date: Fri, 20 Oct 2017 00:52:30 -0700 [thread overview]
Message-ID: <20171020075230.GA31536@infradead.org> (raw)
In-Reply-To: <20171019202838.GA43223@beast>
On Thu, Oct 19, 2017 at 01:28:38PM -0700, Kees Cook wrote:
> Under LOCKDEP, the timer lock_class_key (set up in __setup_timer) needs
> to be tied to the caller's context, so an inline for timer_setup()
> won't work. We do, however, want to keep the inline version around for
> argument type checking, though, so this provides macro wrappers in the
> LOCKDEP case.
Heh, when I tried to do inline setup_timer Arnd had actually pointed
that out in the review..
prev parent reply other threads:[~2017-10-20 7:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 20:28 [PATCH] timer: Provide wrappers safe for use with LOCKDEP Kees Cook
2017-10-20 7:52 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020075230.GA31536@infradead.org \
--to=hch@infradead.org \
--cc=cgallek@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).