netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: "Sven Müller" <musv@gmx.de>
Cc: "Grégory Clement" <gregory.clement@free-electrons.com>,
	"Antoine Ténart" <antoine.tenart@free-electrons.com>,
	netdev@vger.kernel.org, "Marcin Wojtas" <mw@semihalf.com>
Subject: Re: Problems with mvneta
Date: Fri, 20 Oct 2017 09:09:56 +0200	[thread overview]
Message-ID: <20171020090956.2b6cc34b@windsurf.home> (raw)
In-Reply-To: <20171020002524.4b4cf122@gmx.de>

Hello,

On Fri, 20 Oct 2017 00:25:24 +0200, Sven Müller wrote:

> First of all I'm not familiar with kernel programming at all, so
> please excuse me, if I don't understand everything at the first
> glance. 

No problem. Your bug report and effort to nail down the issue are much
appreciated!

> It compiles and runs fine. After a couple of hours and testing no
> issues were found. 

OK, so this really hints at a regression in the mvneta driver itself.

Could you try to revert just:

  6ad20165d376fa07919a70e4f43dfae564601829
  a29b6235560a1ed10c8e1a73bfc616a66b802b90
  2a90f7e1d5d04e4f1060268e0b55a2c702bbd67a

first all of them, and then each one by one, so that we can pin-point
the commit that causes the breakage ?

I looked at all the other changes in mvneta between 4.10 and 4.12, and
I don't see how any of the other changes can cause a functional
difference. So let's focus on those 3 commits for the moment.

Assuming you're using Git, to revert a commit just do: "git revert
<commitid>".

Thanks again!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-10-20  7:10 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20171018223425.42ce7a74@gmx.de>
2017-10-18 20:55 ` Problems with mvneta Thomas Petazzoni
2017-10-19 22:25   ` Sven Müller
2017-10-20  7:09     ` Thomas Petazzoni [this message]
2017-10-23  6:29       ` Andreas Tobler
2017-10-23  9:30         ` Sven Müller
2017-10-31 14:23           ` Sven Müller
2017-10-31 14:27             ` Thomas Petazzoni
2017-10-31 17:09               ` Simon Guinot
2017-10-31 20:23                 ` Thomas Petazzoni
2017-11-01  8:10                   ` Marcin Wojtas
2017-11-08 16:58                     ` [PATCH] net: mvneta: fix handling of the Tx descriptor counter Simon Guinot
2017-11-08 17:03                       ` David Laight
2017-11-08 17:17                       ` Simon Guinot
2017-11-09 19:19                         ` Andreas Tobler
2017-11-11  9:45                       ` David Miller
2017-11-13 14:51                         ` Simon Guinot
2017-11-13 14:54                           ` David Miller
2017-11-13 15:36                             ` Simon Guinot
2017-11-20 14:58                               ` David Laight
2017-11-13 15:27                       ` [PATCH v2] " Simon Guinot
2017-11-14 12:53                         ` David Miller
2017-11-10 10:22             ` [PATCH] " Sven Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171020090956.2b6cc34b@windsurf.home \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=antoine.tenart@free-electrons.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=musv@gmx.de \
    --cc=mw@semihalf.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).