From: David Miller <davem@davemloft.net>
To: sam@mendozajonas.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 2/5] net/ncsi: Stop monitor if channel times out or is inactive
Date: Sat, 21 Oct 2017 01:57:03 +0100 (WEST) [thread overview]
Message-ID: <20171021.015703.687772689628489498.davem@davemloft.net> (raw)
In-Reply-To: <20171019024309.13628-2-sam@mendozajonas.com>
From: Samuel Mendoza-Jonas <sam@mendozajonas.com>
Date: Thu, 19 Oct 2017 13:43:06 +1100
> ncsi_channel_monitor() misses stopping the channel monitor in several
> places that it should, causing a WARN_ON_ONCE() to trigger when the
> monitor is re-started later, eg:
>
> [ 459.040000] WARNING: CPU: 0 PID: 1093 at net/ncsi/ncsi-manage.c:269 ncsi_start_channel_monitor+0x7c/0x90
> [ 459.040000] CPU: 0 PID: 1093 Comm: kworker/0:3 Not tainted 4.10.17-gaca2fdd #140
> [ 459.040000] Hardware name: ASpeed SoC
> [ 459.040000] Workqueue: events ncsi_dev_work
> [ 459.040000] [<80010094>] (unwind_backtrace) from [<8000d950>] (show_stack+0x20/0x24)
> [ 459.040000] [<8000d950>] (show_stack) from [<801dbf70>] (dump_stack+0x20/0x28)
> [ 459.040000] [<801dbf70>] (dump_stack) from [<80018d7c>] (__warn+0xe0/0x108)
> [ 459.040000] [<80018d7c>] (__warn) from [<80018e70>] (warn_slowpath_null+0x30/0x38)
> [ 459.040000] [<80018e70>] (warn_slowpath_null) from [<803f6a08>] (ncsi_start_channel_monitor+0x7c/0x90)
> [ 459.040000] [<803f6a08>] (ncsi_start_channel_monitor) from [<803f7664>] (ncsi_configure_channel+0xdc/0x5fc)
> [ 459.040000] [<803f7664>] (ncsi_configure_channel) from [<803f8160>] (ncsi_dev_work+0xac/0x474)
> [ 459.040000] [<803f8160>] (ncsi_dev_work) from [<8002d244>] (process_one_work+0x1e0/0x450)
> [ 459.040000] [<8002d244>] (process_one_work) from [<8002d510>] (worker_thread+0x5c/0x570)
> [ 459.040000] [<8002d510>] (worker_thread) from [<80033614>] (kthread+0x124/0x164)
> [ 459.040000] [<80033614>] (kthread) from [<8000a5e8>] (ret_from_fork+0x14/0x2c)
>
> This also updates the monitor instead of just returning if
> ncsi_xmit_cmd() fails to send the get-link-status command so that the
> monitor properly times out.
>
> Fixes: e6f44ed6d04d3 "net/ncsi: Package and channel management"
>
> Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
Applied.
next prev parent reply other threads:[~2017-10-21 0:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 2:43 [PATCH net 1/5] net/ncsi: Fix AEN HNCDSC packet length Samuel Mendoza-Jonas
2017-10-19 2:43 ` [PATCH net 2/5] net/ncsi: Stop monitor if channel times out or is inactive Samuel Mendoza-Jonas
2017-10-21 0:57 ` David Miller [this message]
2017-10-19 2:43 ` [PATCH net 3/5] net/ncsi: Disable HWA mode when no channels are found Samuel Mendoza-Jonas
2017-10-21 0:57 ` David Miller
2017-10-19 2:43 ` [PATCH net 4/5] net/ncsi: Enforce failover on link monitor timeout Samuel Mendoza-Jonas
2017-10-21 0:57 ` David Miller
2017-10-19 2:43 ` [PATCH net 5/5] net/ncsi: Fix length of GVI response packet Samuel Mendoza-Jonas
2017-10-21 0:57 ` David Miller
2017-10-21 0:56 ` [PATCH net 1/5] net/ncsi: Fix AEN HNCDSC packet length David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171021.015703.687772689628489498.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sam@mendozajonas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox