From: David Miller <davem@davemloft.net>
To: decui@microsoft.com
Cc: netdev@vger.kernel.org, sthemmin@microsoft.com,
kys@microsoft.com, devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, vkuznets@redhat.com,
haiyangz@microsoft.com, cavery@redhat.com,
rolf.neugebauer@docker.com, marcelo.cerri@canonical.com,
Jork.Loeser@microsoft.com
Subject: Re: [PATCH net] hv_sock: add locking in the open/close/release code paths
Date: Sat, 21 Oct 2017 02:21:29 +0100 (WEST) [thread overview]
Message-ID: <20171021.022129.807124847963198670.davem@davemloft.net> (raw)
In-Reply-To: <KL1P15301MB0006B746A23A2FCE695D08DEBF420@KL1P15301MB0006.APCP153.PROD.OUTLOOK.COM>
From: Dexuan Cui <decui@microsoft.com>
Date: Thu, 19 Oct 2017 03:33:14 +0000
>
> Without the patch, when hvs_open_connection() hasn't completely established
> a connection (e.g. it has changed sk->sk_state to SS_CONNECTED, but hasn't
> inserted the sock into the connected queue), vsock_stream_connect() may see
> the sk_state change and return the connection to the userspace, and next
> when the userspace closes the connection quickly, hvs_release() may not see
> the connection in the connected queue; finally hvs_open_connection()
> inserts the connection into the queue, but we won't be able to purge the
> connection for ever.
>
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
Applied.
prev parent reply other threads:[~2017-10-21 1:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 3:33 [PATCH net] hv_sock: add locking in the open/close/release code paths Dexuan Cui
2017-10-21 1:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171021.022129.807124847963198670.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Jork.Loeser@microsoft.com \
--cc=cavery@redhat.com \
--cc=decui@microsoft.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.cerri@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=rolf.neugebauer@docker.com \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox