From: David Miller <davem@davemloft.net>
To: garsilva@embeddedor.com
Cc: ubraun@linux.vnet.ibm.com, linux-s390@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: smc_close: mark expected switch fall-throughs
Date: Sun, 22 Oct 2017 02:08:35 +0100 (WEST) [thread overview]
Message-ID: <20171022.020835.2065879880300400886.davem@davemloft.net> (raw)
In-Reply-To: <20171019220244.GA22041@embeddedor.com>
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date: Thu, 19 Oct 2017 17:02:44 -0500
> @@ -360,7 +360,8 @@ static void smc_close_passive_work(struct work_struct *work)
> case SMC_PEERCLOSEWAIT1:
> if (rxflags->peer_done_writing)
> sk->sk_state = SMC_PEERCLOSEWAIT2;
> - /* fall through to check for closing */
> + /* to check for closing */
> + /* fall through */
Gustavo please look at what you are doing to the code.
This was a nice easy to read sentence in the comment, and now
you've chopped it up into two pieces and made it awkward and
more difficult to read.
next prev parent reply other threads:[~2017-10-22 1:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 22:02 [PATCH] net: smc_close: mark expected switch fall-throughs Gustavo A. R. Silva
2017-10-22 1:08 ` David Miller [this message]
2017-10-22 1:21 ` Gustavo A. R. Silva
2017-10-22 1:35 ` [PATCH v2] net: smc_close: mark expected switch fall-through Gustavo A. R. Silva
2017-10-24 9:30 ` David Miller
2017-10-22 2:19 ` [PATCH] net: smc_close: mark expected switch fall-throughs David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171022.020835.2065879880300400886.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=garsilva@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ubraun@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).