From: David Miller <davem@davemloft.net>
To: bernd.edlinger@hotmail.de
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] stmmac: Don't access tx_q->dirty_tx before netif_tx_lock
Date: Sun, 22 Oct 2017 03:25:05 +0100 (WEST) [thread overview]
Message-ID: <20171022.032505.1139984864002614492.davem@davemloft.net> (raw)
In-Reply-To: <AM5PR0701MB2657DAF1EEA20231A0FFF50EE4400@AM5PR0701MB2657.eurprd07.prod.outlook.com>
From: Bernd Edlinger <bernd.edlinger@hotmail.de>
Date: Sat, 21 Oct 2017 06:51:30 +0000
> This is the possible reason for different hard to reproduce
> problems on my ARMv7-SMP test system.
>
> The symptoms are in recent kernels imprecise external aborts,
> and in older kernels various kinds of network stalls and
> unexpected page allocation failures.
>
> My testing indicates that the trouble started between v4.5 and v4.6
> and prevails up to v4.14.
>
> Using the dirty_tx before acquiring the spin lock is clearly
> wrong and was first introduced with v4.6.
>
> Fixes: e3ad57c96715 ("stmmac: review RX/TX ring management")
>
> Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
Applied, thank you.
prev parent reply other threads:[~2017-10-22 2:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-21 6:51 [PATCH] stmmac: Don't access tx_q->dirty_tx before netif_tx_lock Bernd Edlinger
2017-10-22 2:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171022.032505.1139984864002614492.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=bernd.edlinger@hotmail.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox