From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Saeed Mahameed <saeedm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Alex Vesker <valex-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [for-next 08/12] net/mlx5e: IPoIB, Use hash-table to map between QPN to child netdev
Date: Mon, 23 Oct 2017 09:47:36 -0600 [thread overview]
Message-ID: <20171023154736.GF11952@obsidianresearch.com> (raw)
In-Reply-To: <20171014184827.18491-9-saeedm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
On Sat, Oct 14, 2017 at 11:48:23AM -0700, Saeed Mahameed wrote:
> From: Alex Vesker <valex-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
> This change is needed for PKEY support, since the RQs are shared
> between the child interface and the parent. The parent is responsible
> for NAPI and the precessing of RX completions. Using the dqpn in the
> completion descriptor we set the corresponding child IPoIB netdevice
> on the SKB.
> The mapping between the dqpn and the netdevice is done using a HT,
> each mlx5 IPoIB interface registers its mapping on creation.
It seems really really weird to share the receive Q across all of the
children and do the sorting in software.. why is this done like this?
Wouldn't it be better to allow the children to progress concurrently,
potentially on multiple cores? They all have their own QPs after all..
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-10-23 15:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-14 18:48 [pull request][for-next 00/12] Mellanox, mlx5 IPoIB Muli Pkey support 2017-10-11 Saeed Mahameed
2017-10-14 18:48 ` [for-next 02/12] net/mlx5: PTP code migration to driver core section Saeed Mahameed
2017-10-14 18:48 ` [for-next 04/12] net/mlx5: Support for attaching multiple underlay QPs to root flow table Saeed Mahameed
2017-10-14 18:48 ` [for-next 05/12] IB/ipoib: Grab rtnl lock on heavy flush when calling ndo_open/stop Saeed Mahameed
2017-10-14 18:48 ` [for-next 06/12] IB/ipoib: Add ability to set PKEY index to lower device driver Saeed Mahameed
2017-10-14 18:48 ` [for-next 07/12] net/mlx5e: IPoIB, Support for setting PKEY index to underlay QP Saeed Mahameed
2017-10-14 18:48 ` [for-next 09/12] net/mlx5e: IPoIB, Add PKEY child interface nic profile Saeed Mahameed
2017-10-14 18:48 ` [for-next 10/12] net/mlx5e: IPoIB, Add PKEY child interface ndos Saeed Mahameed
[not found] ` <20171014184827.18491-1-saeedm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-14 18:48 ` [for-next 01/12] net/mlx5: File renaming towards ptp core implementation Saeed Mahameed
2017-10-14 18:48 ` [for-next 03/12] net/mlx5e: IPoIB, Move underlay QP init/uninit to separate functions Saeed Mahameed
2017-10-14 18:48 ` [for-next 08/12] net/mlx5e: IPoIB, Use hash-table to map between QPN to child netdev Saeed Mahameed
[not found] ` <20171014184827.18491-9-saeedm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-23 15:47 ` Jason Gunthorpe [this message]
2017-10-24 6:28 ` Alex Vesker
2017-10-14 18:48 ` [for-next 11/12] net/mlx5e: IPoIB, Add PKEY child interface ethtool ops Saeed Mahameed
2017-10-14 21:19 ` [pull request][for-next 00/12] Mellanox, mlx5 IPoIB Muli Pkey support 2017-10-11 Doug Ledford
2017-10-15 6:30 ` Leon Romanovsky
2017-10-16 4:45 ` [pull request][for-next 00/12] Mellanox, mlx5 IPoIB Muli Pkey support 2017-10-11,Re: " David Miller
[not found] ` <20171016.054503.459455425504112937.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2017-10-18 15:08 ` Doug Ledford
2017-10-14 18:48 ` [for-next 12/12] net/mlx5e: IPoIB, Modify rdma netdev allocate and free to support PKEY Saeed Mahameed
2017-10-14 22:51 ` [pull request][for-next 00/12] Mellanox, mlx5 IPoIB Muli Pkey support 2017-10-11 Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171023154736.GF11952@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=saeedm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=valex-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).