From: Matthias Kaehlcke <mka@chromium.org>
To: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Cc: linux-wimax@intel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Behan Webster <behanw@converseincode.com>,
Mark Charlebois <charlebm@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH] wimax/i2400m: Remove VLAIS
Date: Tue, 24 Oct 2017 12:46:59 -0700 [thread overview]
Message-ID: <20171024194659.GC96615@google.com> (raw)
In-Reply-To: <20171009194153.30467-1-mka@chromium.org>
El Mon, Oct 09, 2017 at 12:41:53PM -0700 Matthias Kaehlcke ha dit:
> From: Behan Webster <behanw@converseincode.com>
>
> Convert Variable Length Array in Struct (VLAIS) to valid C by converting
> local struct definition to use a flexible array. The structure is only
> used to define a cast of a buffer so the size of the struct is not used
> to allocate storage.
>
> Signed-off-by: Behan Webster <behanw@converseincode.com>
> Signed-off-by: Mark Charebois <charlebm@gmail.com>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> drivers/net/wimax/i2400m/fw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wimax/i2400m/fw.c b/drivers/net/wimax/i2400m/fw.c
> index c9c711dcd0e6..a89b5685e68b 100644
> --- a/drivers/net/wimax/i2400m/fw.c
> +++ b/drivers/net/wimax/i2400m/fw.c
> @@ -652,7 +652,7 @@ static int i2400m_download_chunk(struct i2400m *i2400m, const void *chunk,
> struct device *dev = i2400m_dev(i2400m);
> struct {
> struct i2400m_bootrom_header cmd;
> - u8 cmd_payload[chunk_len];
> + u8 cmd_payload[];
> } __packed *buf;
> struct i2400m_bootrom_header ack;
ping
any comments on this?
next prev parent reply other threads:[~2017-10-24 19:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 19:41 [PATCH] wimax/i2400m: Remove VLAIS Matthias Kaehlcke
2017-10-24 19:46 ` Matthias Kaehlcke [this message]
2017-10-24 21:00 ` Perez-Gonzalez, Inaky
2017-10-25 15:57 ` Dan Williams
2017-10-25 17:12 ` Perez-Gonzalez, Inaky
2017-10-25 17:39 ` Dan Williams
2017-10-25 21:06 ` Perez-Gonzalez, Inaky
2017-10-25 21:01 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024194659.GC96615@google.com \
--to=mka@chromium.org \
--cc=arnd@arndb.de \
--cc=behanw@converseincode.com \
--cc=charlebm@gmail.com \
--cc=groeck@chromium.org \
--cc=inaky.perez-gonzalez@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wimax@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).