From: Stefano Brivio <sbrivio@redhat.com>
To: davem@davemloft.net
Cc: Xin Long <lucien.xin@gmail.com>,
network dev <netdev@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
hannes@stressinduktion.org
Subject: Re: [PATCH net 0/6] rtnetlink: a bunch of fixes for userspace notifications in changing dev properties
Date: Tue, 24 Oct 2017 22:44:19 +0200 [thread overview]
Message-ID: <20171024224419.5f85ea71@elisabeth> (raw)
In-Reply-To: <cover.1508062280.git.lucien.xin@gmail.com>
On Sun, 15 Oct 2017 18:13:40 +0800
Xin Long <lucien.xin@gmail.com> wrote:
> Whenever any property of a link, address, route, etc. changes by whatever way,
> kernel should notify the programs that listen for such events in userspace.
>
> The patchet "rtnetlink: Cleanup user notifications for netdev events" tried to
> fix a redundant notifications issue, but it also introduced a side effect.
>
> After that, user notifications could only be sent when changing dev properties
> via netlink api. As it removed some events process in rtnetlink_event where
> the notifications was sent to users.
>
> It resulted in no notification generated when dev properties are changed via
> other ways, like ioctl, sysfs, etc. It may cause some user programs doesn't
> work as expected because of the missing notifications.
>
> This patchset will fix it by bringing some of these netdev events back and
> also fix the old redundant notifications issue with a proper way.
>
> Xin Long (6):
> rtnetlink: bring NETDEV_CHANGEMTU event process back in
> rtnetlink_event
> rtnetlink: bring NETDEV_CHANGE_TX_QUEUE_LEN event process back in
> rtnetlink_event
> rtnetlink: bring NETDEV_POST_TYPE_CHANGE event process back in
> rtnetlink_event
> rtnetlink: bring NETDEV_CHANGEUPPER event process back in
> rtnetlink_event
> rtnetlink: check DO_SETLINK_NOTIFY correctly in do_setlink
> rtnetlink: do not set notification for tx_queue_len in do_setlink
I guess this should be considered for -stable (back to 4.12), as it
fixes quite a few critical issues in notification behaviours userspace
might rely on.
--
Stefano
prev parent reply other threads:[~2017-10-24 20:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-15 10:13 [PATCH net 0/6] rtnetlink: a bunch of fixes for userspace notifications in changing dev properties Xin Long
2017-10-15 10:13 ` [PATCH net 1/6] rtnetlink: bring NETDEV_CHANGEMTU event process back in rtnetlink_event Xin Long
2017-10-15 10:13 ` [PATCH net 2/6] rtnetlink: bring NETDEV_CHANGE_TX_QUEUE_LEN " Xin Long
2017-10-15 10:13 ` [PATCH net 3/6] rtnetlink: bring NETDEV_POST_TYPE_CHANGE " Xin Long
2017-10-15 10:13 ` [PATCH net 4/6] rtnetlink: bring NETDEV_CHANGEUPPER " Xin Long
2017-10-15 10:13 ` [PATCH net 5/6] rtnetlink: check DO_SETLINK_NOTIFY correctly in do_setlink Xin Long
2017-10-15 10:13 ` [PATCH net 6/6] rtnetlink: do not set notification for tx_queue_len " Xin Long
2017-10-16 1:17 ` David Ahern
2017-10-16 1:17 ` [PATCH net 5/6] rtnetlink: check DO_SETLINK_NOTIFY correctly " David Ahern
2017-10-16 12:20 ` Nicolas Dichtel
2017-10-26 6:52 ` Vlad Yasevich
2017-10-26 7:41 ` Nicolas Dichtel
2017-10-26 8:21 ` [PATCH net] Revert "rtnetlink: check DO_SETLINK_NOTIFY correctly in do_setlink" Nicolas Dichtel
2017-10-26 9:10 ` Xin Long
2017-10-26 10:18 ` Nicolas Dichtel
2017-10-26 15:22 ` David Ahern
2017-10-27 13:27 ` David Miller
2017-10-26 14:59 ` [PATCH net 5/6] rtnetlink: check DO_SETLINK_NOTIFY correctly in do_setlink David Ahern
2017-10-16 1:16 ` [PATCH net 4/6] rtnetlink: bring NETDEV_CHANGEUPPER event process back in rtnetlink_event David Ahern
2017-10-16 1:16 ` [PATCH net 3/6] rtnetlink: bring NETDEV_POST_TYPE_CHANGE " David Ahern
2017-10-16 1:16 ` [PATCH net 2/6] rtnetlink: bring NETDEV_CHANGE_TX_QUEUE_LEN " David Ahern
2017-10-16 19:49 ` [PATCH net 0/6] rtnetlink: a bunch of fixes for userspace notifications in changing dev properties David Miller
2017-10-24 20:44 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024224419.5f85ea71@elisabeth \
--to=sbrivio@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).