From: Jiri Pirko <jiri@resnulli.us>
To: Steve Lin <steven.lin1@broadcom.com>
Cc: netdev@vger.kernel.org, jiri@mellanox.com, davem@davemloft.net,
michael.chan@broadcom.com, linville@tuxdriver.com,
gospo@broadcom.com, yuvalm@mellanox.com
Subject: Re: [PATCH net-next v3 02/10] devlink: Adding SR-IOV enablement perm config param
Date: Wed, 25 Oct 2017 11:29:35 +0200 [thread overview]
Message-ID: <20171025092935.GC1971@nanopsycho> (raw)
In-Reply-To: <1508875962-39233-3-git-send-email-steven.lin1@broadcom.com>
Tue, Oct 24, 2017 at 10:12:34PM CEST, steven.lin1@broadcom.com wrote:
>Adding DEVLINK_PERM_CONFIG_SRIOV_ENABLED permanent config
>parameter. Value is permanent, so becomes the new default
>value for this device.
>
> 0 = Disable SR-IOV
> 1 = Enable SR-IOV
>
>Signed-off-by: Steve Lin <steven.lin1@broadcom.com>
>Acked-by: Andy Gospodarek <gospo@broadcom.com>
>---
> include/uapi/linux/devlink.h | 8 +++++++-
> net/core/devlink.c | 1 +
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
>diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
>index 28ea961..ed520e7 100644
>--- a/include/uapi/linux/devlink.h
>+++ b/include/uapi/linux/devlink.h
>@@ -256,8 +256,14 @@ enum devlink_dpipe_header_id {
> DEVLINK_DPIPE_HEADER_IPV6,
> };
>
>-/* Permanent config parameters */
>+/* Permanent config parameters:
>+ * DEVLINK_PERM_CONFIG_SRIOV_ENABLED:
>+ * 0 = disable SR-IOV
>+ * 1 = enable SR-IOV
Enum please. Also, I would like to see more detailed description,
including description how exactly the driver is expected to behave.
Current description is still quite vague.
>+ */
> enum devlink_perm_config_param {
>+ DEVLINK_PERM_CONFIG_SRIOV_ENABLED,
>+
> __DEVLINK_PERM_CONFIG_MAX,
> DEVLINK_PERM_CONFIG_MAX = __DEVLINK_PERM_CONFIG_MAX - 1
> };
>diff --git a/net/core/devlink.c b/net/core/devlink.c
>index 4deb4da..58ba715 100644
>--- a/net/core/devlink.c
>+++ b/net/core/devlink.c
>@@ -1569,6 +1569,7 @@ static int devlink_nl_cmd_eswitch_set_doit(struct sk_buff *skb,
> static const struct nla_policy devlink_nl_policy[DEVLINK_ATTR_MAX + 1];
>
> static const u8 devlink_perm_cfg_param_types[DEVLINK_PERM_CONFIG_MAX + 1] = {
>+ [DEVLINK_PERM_CONFIG_SRIOV_ENABLED] = NLA_U8,
> };
>
> static int devlink_nl_single_param_get(struct sk_buff *msg,
>--
>2.7.4
>
next prev parent reply other threads:[~2017-10-25 9:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 20:12 [PATCH net-next v3 00/10] Adding permanent config get/set to devlink Steve Lin
2017-10-24 20:12 ` [PATCH net-next v3 01/10] devlink: Add permanent config parameter get/set operations Steve Lin
2017-10-24 21:22 ` Yuval Mintz
2017-10-25 2:14 ` Steve Lin
2017-10-25 5:41 ` Yuval Mintz
2017-10-25 2:53 ` David Miller
2017-10-25 9:13 ` Jiri Pirko
2017-10-24 20:12 ` [PATCH net-next v3 02/10] devlink: Adding SR-IOV enablement perm config param Steve Lin
2017-10-25 5:41 ` Yuval Mintz
2017-10-25 9:29 ` Jiri Pirko [this message]
2017-10-24 20:12 ` [PATCH net-next v3 03/10] devlink: Adding num VFs per PF permanent " Steve Lin
2017-10-25 5:41 ` Yuval Mintz
2017-10-24 20:12 ` [PATCH net-next v3 04/10] devlink: Adding max PF MSI-X vectors perm " Steve Lin
2017-10-24 20:12 ` [PATCH net-next v3 05/10] devlink: Adding num MSI-X vectors per VF " Steve Lin
2017-10-24 20:12 ` [PATCH net-next v3 06/10] bnxt: Add devlink support for config get/set Steve Lin
2017-10-24 20:52 ` Michael Chan
2017-10-25 2:01 ` Steve Lin
2017-10-25 5:55 ` Yuval Mintz
2017-10-25 6:40 ` Michael Chan
2017-10-24 20:12 ` [PATCH net-next v3 07/10] bnxt: Adding SR-IOV enablement permanent cfg param Steve Lin
2017-10-24 20:12 ` [PATCH net-next v3 08/10] bnxt: Adding num VFs per PF perm config param Steve Lin
2017-10-24 20:12 ` [PATCH net-next v3 09/10] bnxt: Adding max PF MSI-X vectors " Steve Lin
2017-10-24 20:12 ` [PATCH net-next v3 10/10] bnxt: Adding num MSI-X vectors per VF " Steve Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171025092935.GC1971@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=gospo@broadcom.com \
--cc=jiri@mellanox.com \
--cc=linville@tuxdriver.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=steven.lin1@broadcom.com \
--cc=yuvalm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).