From: Andrei Vagin <avagin@virtuozzo.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Andrei Vagin <avagin@openvz.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net/unix: don't show information about sockets from other namespaces
Date: Wed, 25 Oct 2017 12:00:52 -0700 [thread overview]
Message-ID: <20171025190051.GA10391@outlook.office365.com> (raw)
In-Reply-To: <1508938636.30291.115.camel@edumazet-glaptop3.roam.corp.google.com>
On Wed, Oct 25, 2017 at 06:37:16AM -0700, Eric Dumazet wrote:
> On Wed, 2017-10-25 at 00:17 -0700, Andrei Vagin wrote:
> > socket_diag shows information only about sockets from a namespace where
> > a diag socket lives.
> >
> > But if we request information about one unix socket, the kernel don't
> > check that its netns is matched with a diag socket namespace, so any
> > user can get information about any unix socket in a system. This looks
> > like a bug.
>
> Then if this a bug please provide a Fixes: tag
>
> This way, we can know exact cutoff for backports.
>
> I suspect that would be
>
> Fixes: 51d7cccf0723 ("net: make sock diag per-namespace")
Thank you, Eric. It's my fault, I forgot to add it.
>
> Thanks.
>
>
prev parent reply other threads:[~2017-10-25 19:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 7:17 [PATCH] net/unix: don't show information about sockets from other namespaces Andrei Vagin
2017-10-25 13:37 ` Eric Dumazet
2017-10-25 17:16 ` [PATCH v2] " Andrei Vagin
2017-10-26 1:06 ` David Miller
2017-10-25 19:00 ` Andrei Vagin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171025190051.GA10391@outlook.office365.com \
--to=avagin@virtuozzo.com \
--cc=avagin@openvz.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).