Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: Haakon.Bugge@oracle.com
Cc: santosh.shilimkar@oracle.com, netdev@vger.kernel.org,
	linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rds: Fix inaccurate accounting of unsignaled wrs
Date: Thu, 26 Oct 2017 17:36:26 +0900 (KST)	[thread overview]
Message-ID: <20171026.173626.1982523888757754892.davem@davemloft.net> (raw)
In-Reply-To: <20171024141628.14637-1-Haakon.Bugge@oracle.com>

From: Håkon Bugge <Haakon.Bugge@oracle.com>
Date: Tue, 24 Oct 2017 16:16:28 +0200

> The number of unsignaled work-requests posted to the IB send queue is
> tracked by a counter in the rds_ib_connection struct. When it reaches
> zero, or the caller explicitly asks for it, the send-signaled bit is
> set in send_flags and the counter is reset. This is performed by the
> rds_ib_set_wr_signal_state() function.
> 
> However, this function is not always used which yields inaccurate
> accounting. This commit fixes this, re-factors a code bloat related to
> the matter, and makes the actual parameter type to the function
> consistent.
> 
> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>

Applied.

      parent reply	other threads:[~2017-10-26  8:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-24 14:16 [PATCH] rds: Fix inaccurate accounting of unsignaled wrs Håkon Bugge
2017-10-24 16:05 ` Santosh Shilimkar
     [not found]   ` <663DF75A-36AC-4589-83B2-D664672CF374@oracle.com>
     [not found]     ` <663DF75A-36AC-4589-83B2-D664672CF374-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-10-24 16:36       ` Santosh Shilimkar
2017-10-26  8:36 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171026.173626.1982523888757754892.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Haakon.Bugge@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rds-devel@oss.oracle.com \
    --cc=santosh.shilimkar@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox