From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters Date: Thu, 26 Oct 2017 23:56:29 +0200 Message-ID: <20171026215629.GB8489@lunn.ch> References: <23152048-09fe-2950-e1ff-8cf90ca3f465@synopsys.com> <20171026090308.GD20299@lunn.ch> <867d6d43-9df7-4097-db5a-f2049236394f@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Florian Fainelli , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "David S. Miller" , Joao Pinto , Giuseppe Cavallaro , Alexandre Torgue , Rob Herring To: Jose Abreu Return-path: Content-Disposition: inline In-Reply-To: <867d6d43-9df7-4097-db5a-f2049236394f-HKixBCOQz3hWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org > About my patches, what I think would be better now would be to > drop the configuration by DT and integrate the remaining > configuration, letting the EST parameters be populated by SoC > specific wrappers. Hi Jose The problem with SoC specific wrappers is that you are going to have to remove them once the real interface is defined. Anybody who uses your SoC specific wrappers is going to have to re-write their code, when it all gets ripped out. You generally don't add device SoC specific wrappers. Imagine if everybody did that. Lots of different ways of doing the same thing. My suggesting is to keep your patches out for the moment, waiting for generic support to be added. Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html