From: Stephen Hemminger <stephen@networkplumber.org>
To: Roman Mashak <mrv@mojatatu.com>
Cc: jhs@mojatatu.com, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 1/1] tc: distinguish Add/Replace qdisc operations
Date: Fri, 27 Oct 2017 09:36:48 +0200 [thread overview]
Message-ID: <20171027093648.7bd93253@shemminger-XPS-13-9360> (raw)
In-Reply-To: <1509053408-18007-1-git-send-email-mrv@mojatatu.com>
On Thu, 26 Oct 2017 17:30:08 -0400
Roman Mashak <mrv@mojatatu.com> wrote:
> Signed-off-by: Roman Mashak <mrv@mojatatu.com>
> ---
> tc/tc_qdisc.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/tc/tc_qdisc.c b/tc/tc_qdisc.c
> index 1e9d909..493538c 100644
> --- a/tc/tc_qdisc.c
> +++ b/tc/tc_qdisc.c
> @@ -231,6 +231,16 @@ int print_qdisc(const struct sockaddr_nl *who,
> if (n->nlmsg_type == RTM_DELQDISC)
> fprintf(fp, "deleted ");
>
> + if (n->nlmsg_type == RTM_NEWQDISC &&
> + (n->nlmsg_flags & NLM_F_CREATE) &&
> + (n->nlmsg_flags & NLM_F_REPLACE))
> + fprintf(fp, "replaced ");
> +
> + if (n->nlmsg_type == RTM_NEWQDISC &&
> + (n->nlmsg_flags & NLM_F_CREATE) &&
> + (n->nlmsg_flags & NLM_F_EXCL))
> + fprintf(fp, "added ");
> +
> if (show_raw)
> fprintf(fp, "qdisc %s %x:[%08x] ",
> rta_getattr_str(tb[TCA_KIND]),
I am not sure about this. We don't do this for monitoring routes or addresses.
next prev parent reply other threads:[~2017-10-27 7:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 21:30 [PATCH iproute2 1/1] tc: distinguish Add/Replace qdisc operations Roman Mashak
2017-10-27 7:36 ` Stephen Hemminger [this message]
2017-10-27 14:02 ` Roman Mashak
2017-11-12 23:59 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171027093648.7bd93253@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=jhs@mojatatu.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox