From: Jiri Pirko <jiri@resnulli.us>
To: Steve Lin <steven.lin1@broadcom.com>
Cc: netdev@vger.kernel.org, jiri@mellanox.com, davem@davemloft.net,
michael.chan@broadcom.com, linville@tuxdriver.com,
gospo@broadcom.com, yuvalm@mellanox.com
Subject: Re: [PATCH net-next v4 01/10] devlink: Add permanent config parameter get/set operations
Date: Fri, 27 Oct 2017 23:04:55 +0200 [thread overview]
Message-ID: <20171027210455.GC1980@nanopsycho.orion> (raw)
In-Reply-To: <1509137654-1580-2-git-send-email-steven.lin1@broadcom.com>
Fri, Oct 27, 2017 at 10:54:05PM CEST, steven.lin1@broadcom.com wrote:
>Add support for permanent config parameter get/set commands. Used
>for persistent device configuration parameters.
>
>Signed-off-by: Steve Lin <steven.lin1@broadcom.com>
>Acked-by: Andy Gospodarek <gospo@broadcom.com>
>---
> include/net/devlink.h | 7 ++
> include/uapi/linux/devlink.h | 25 ++++
> net/core/devlink.c | 287 +++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 319 insertions(+)
>
>diff --git a/include/net/devlink.h b/include/net/devlink.h
>index b9654e1..c7dd912 100644
>--- a/include/net/devlink.h
>+++ b/include/net/devlink.h
>@@ -270,6 +270,13 @@ struct devlink_ops {
> int (*eswitch_inline_mode_set)(struct devlink *devlink, u8 inline_mode);
> int (*eswitch_encap_mode_get)(struct devlink *devlink, u8 *p_encap_mode);
> int (*eswitch_encap_mode_set)(struct devlink *devlink, u8 encap_mode);
>+ int (*perm_config_get)(struct devlink *devlink,
>+ enum devlink_perm_config_param param, u8 type,
>+ union devlink_perm_config_value *value);
>+ int (*perm_config_set)(struct devlink *devlink,
>+ enum devlink_perm_config_param param, u8 type,
>+ union devlink_perm_config_value *value,
>+ u8 *restart_reqd);
type should be enum and restart_reqd should be bool.
[...]
>+static int devlink_nl_single_param_set(struct sk_buff *msg,
>+ struct devlink *devlink,
>+ u32 param, u8 type,
>+ union devlink_perm_config_value *value)
>+{
>+ const struct devlink_ops *ops = devlink->ops;
>+ struct nlattr *cfgparam_attr;
>+ u8 need_restart;
>+ int err;
>+
>+ /* Now set parameter */
>+ err = ops->perm_config_set(devlink, param, type, value, &need_restart);
>+ if (err)
>+ return err;
>+
>+ cfgparam_attr = nla_nest_start(msg, DEVLINK_ATTR_PERM_CONFIG);
>+ /* Update restart reqd - if any param needs restart, should be set */
>+ if (need_restart) {
>+ err = nla_put_u8(msg,
>+ DEVLINK_ATTR_PERM_CONFIG_RESTART_REQUIRED, 1);
Why don't you just put this flag always? Otherwise it could be NLA_FLAG
>+ if (err)
>+ goto nest_fail;
>+ }
>+
next prev parent reply other threads:[~2017-10-27 21:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 20:54 [PATCH net-next v4 00/10] Adding permanent config get/set to devlink Steve Lin
2017-10-27 20:54 ` [PATCH net-next v4 01/10] devlink: Add permanent config parameter get/set operations Steve Lin
2017-10-27 21:04 ` Jiri Pirko [this message]
2017-10-27 21:26 ` Steve Lin
2017-10-28 7:16 ` Jiri Pirko
2017-10-27 20:54 ` [PATCH net-next v4 02/10] devlink: Adding SR-IOV enablement perm config param Steve Lin
2017-10-27 21:06 ` Jiri Pirko
2017-10-27 21:30 ` Steve Lin
2017-10-28 7:17 ` Jiri Pirko
2017-10-27 20:54 ` [PATCH net-next v4 03/10] devlink: Adding num VFs per PF permanent " Steve Lin
2017-10-27 20:54 ` [PATCH net-next v4 04/10] devlink: Adding max PF MSI-X vectors perm " Steve Lin
2017-10-27 20:54 ` [PATCH net-next v4 05/10] devlink: Adding num MSI-X vectors per VF " Steve Lin
2017-10-27 20:54 ` [PATCH net-next v4 06/10] bnxt: Add devlink support for config get/set Steve Lin
2017-10-27 20:54 ` [PATCH net-next v4 07/10] bnxt: Adding SR-IOV enablement permanent cfg param Steve Lin
2017-10-27 20:54 ` [PATCH net-next v4 08/10] bnxt: Adding num VFs per PF perm config param Steve Lin
2017-10-27 20:54 ` [PATCH net-next v4 09/10] bnxt: Adding max PF MSI-X vectors " Steve Lin
2017-10-27 20:54 ` [PATCH net-next v4 10/10] bnxt: Adding num MSI-X vectors per VF " Steve Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171027210455.GC1980@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=gospo@broadcom.com \
--cc=jiri@mellanox.com \
--cc=linville@tuxdriver.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=steven.lin1@broadcom.com \
--cc=yuvalm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).