From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next v4 02/10] devlink: Adding SR-IOV enablement perm config param Date: Fri, 27 Oct 2017 23:06:51 +0200 Message-ID: <20171027210651.GD1980@nanopsycho.orion> References: <1509137654-1580-1-git-send-email-steven.lin1@broadcom.com> <1509137654-1580-3-git-send-email-steven.lin1@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, jiri@mellanox.com, davem@davemloft.net, michael.chan@broadcom.com, linville@tuxdriver.com, gospo@broadcom.com, yuvalm@mellanox.com To: Steve Lin Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:54446 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932329AbdJ0VGx (ORCPT ); Fri, 27 Oct 2017 17:06:53 -0400 Received: by mail-wm0-f68.google.com with SMTP id r68so5996086wmr.3 for ; Fri, 27 Oct 2017 14:06:52 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1509137654-1580-3-git-send-email-steven.lin1@broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: Fri, Oct 27, 2017 at 10:54:06PM CEST, steven.lin1@broadcom.com wrote: >Adding DEVLINK_PERM_CONFIG_SRIOV_ENABLED permanent config >parameter. Value is permanent, so becomes the new default Avoid the double space. >value for this device. > > DEVLINK_PERM_CONFIG_DISABLE = Disable SR-IOV > DEVLINK_PERM_CONFIG_ENABLE = Enable SR-IOV > >Signed-off-by: Steve Lin >Acked-by: Andy Gospodarek >--- > include/uapi/linux/devlink.h | 14 +++++++++++++- > net/core/devlink.c | 1 + > 2 files changed, 14 insertions(+), 1 deletion(-) > >diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h >index b3a0b2a..9a41f6e 100644 >--- a/include/uapi/linux/devlink.h >+++ b/include/uapi/linux/devlink.h >@@ -256,8 +256,20 @@ enum devlink_dpipe_header_id { > DEVLINK_DPIPE_HEADER_IPV6, > }; > >-/* Permanent config parameters */ >+enum devlink_perm_config_enabled { >+ DEVLINK_PERM_CONFIG_DISABLE, >+ DEVLINK_PERM_CONFIG_ENABLE, >+}; >+ >+/* Permanent config parameters: >+ * DEVLINK_PERM_CONFIG_SRIOV_ENABLED: Configures whether SR-IOV PCI capability >+ * provided by device. I don't understand the sentense :/ >+ * DEVLINK_PERM_CONFIG_DISABLE = disable SR-IOV >+ * DEVLINK_PERM_CONFIG_ENABLE = enable SR-IOV These comments should be at the enum values, not here. >+ */ > enum devlink_perm_config_param { >+ DEVLINK_PERM_CONFIG_SRIOV_ENABLED, >+ > __DEVLINK_PERM_CONFIG_MAX, > DEVLINK_PERM_CONFIG_MAX = __DEVLINK_PERM_CONFIG_MAX - 1 > }; >diff --git a/net/core/devlink.c b/net/core/devlink.c >index a7fa7cc..395c93c 100644 >--- a/net/core/devlink.c >+++ b/net/core/devlink.c >@@ -1569,6 +1569,7 @@ static int devlink_nl_cmd_eswitch_set_doit(struct sk_buff *skb, > static const struct nla_policy devlink_nl_policy[DEVLINK_ATTR_MAX + 1]; > > static const u8 devlink_perm_cfg_param_types[DEVLINK_PERM_CONFIG_MAX + 1] = { >+ [DEVLINK_PERM_CONFIG_SRIOV_ENABLED] = NLA_U8, > }; > > static int devlink_nl_single_param_get(struct sk_buff *msg, >-- >2.7.4 >