From: Harald Welte <laforge@gnumonks.org>
To: Tom Herbert <tom@quantonium.net>
Cc: davem@davemloft.net, pablo@netfilter.org, aschultz@tpip.net,
netdev@vger.kernel.org, rohit@quantonium.net
Subject: Re: [PATCH v7 net-next 00/13] gtp: Additional feature support - Part I
Date: Sat, 28 Oct 2017 10:09:40 +0200 [thread overview]
Message-ID: <20171028080940.dvtzn2cg2rrk6f6t@nataraja> (raw)
In-Reply-To: <20171028000937.2631-1-tom@quantonium.net>
Hi Tom,
my apologies for only getting back to reviews now, after return from
holidays I was too overloaded with plenty of other tasks.
On Fri, Oct 27, 2017 at 05:09:24PM -0700, Tom Herbert wrote:
> - Experimental IPv6 support
As far as I can tell, my previous comments/concerns regarding an IPv6
support that is in clear violation of how it is specified is not
acceptable to me, sorry.
The question is - as illustrated quite verbosely before - not one
of missing certain bits, but it is simply *different* from what
the protocol specification says.
This makes absolutely no sense to me. All it will do, is it will raise
the impression that IPv6 is supported in a spec-compliant way.
Furthermore, it will mean that once somebody does convert this into
proper IPv6 support later, they will break the existing use cases of
the non-compliant implementation that you're adding in this patch
series.
To me, I simply don't understand how that makes any sense. There are no
known users of GTP outside of 3GPP networks, and particularly none of a
different GTP flavour than the one specified in 3GPP. If there are, I
would want to hear of it. And if there really are, I would strongly
recommend them to use some other tunneling protocol, one that's more
reasonable for normal use cases and with better protocol-level security.
I wouldn't mind merging *incomplete* IPv6 support. However, I do mind
merging *incompatible* or *incompliant* IPv6 support.
> - Configurable networking interfaces so that GTP kernel can be
> used and tested without needing GSN network emulation (i.e. no user
> space daemon needed).
> - Addition of a dst_cache in the GTP structure and other cleanup
No issues with this from my side. I plan on setting up a test system
with your patches over the weekend and give it some more testing from
the use cases I know to avoid regressions.
> - Common functions to get a route fo for an IP tunnel
> - Fix VXLAN gro cells initialization
Also no issues from my side, but that's for core networking folks to
decide.
> For IPv6 support, the mobile subscriber needs to allow IPv6 addresses,
> and the remote endpoint can be IPv6.
You are raising the impression - again - that this implementation will
work with any mobile subscriber. I would bet at lot on the fact that
the current IPv6 implementation will in fact *not* work with any
existing equipment/devices out there.
> Tested:
>
> Configured the matrix of IPv4/IPv6 mobile subscriber,
Please indicate how that testing was done, see my comment above.
Regards,
Harald
--
- Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
next prev parent reply other threads:[~2017-10-28 8:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-28 0:09 [PATCH v7 net-next 00/13] gtp: Additional feature support - Part I Tom Herbert
2017-10-28 0:09 ` [PATCH v7 net-next 01/13] vxlan: Move gro_cells_init to ndo_init Tom Herbert
2017-10-28 0:58 ` Eric Dumazet
2017-10-28 0:09 ` [PATCH v7 net-next 02/13] iptunnel: Add common functions to get a tunnel route Tom Herbert
2017-10-28 0:09 ` [PATCH v7 net-next 03/13] vxlan: Call common functions to get tunnel routes Tom Herbert
2017-10-28 0:09 ` [PATCH v7 net-next 04/13] gtp: Call common functions to get tunnel routes and add dst_cache Tom Herbert
2017-10-28 0:09 ` [PATCH v7 net-next 05/13] iptunnel: Generalize tunnel update pmtu Tom Herbert
2017-10-28 0:09 ` [PATCH v7 net-next 06/13] gtp: Change to use gro_cells Tom Herbert
2017-10-28 1:00 ` Eric Dumazet
2017-10-28 0:09 ` [PATCH v7 net-next 07/13] gtp: Use goto for exceptions in gtp_udp_encap_recv funcs Tom Herbert
2017-10-28 0:09 ` [PATCH v7 net-next 08/13] gtp: udp recv clean up Tom Herbert
2017-10-28 0:09 ` [PATCH v7 net-next 09/13] gtp: Call function to update path mtu Tom Herbert
2017-10-28 0:09 ` [PATCH v7 net-next 10/13] gtp: Eliminate pktinfo and add port configuration Tom Herbert
2017-10-28 0:09 ` [PATCH v7 net-next 11/13] gtp: Experimental encapsulation of IPv6 packets Tom Herbert
2017-10-28 0:09 ` [PATCH v7 net-next 12/13] gtp: Experimental support encpasulating over IPv6 Tom Herbert
2017-10-28 0:09 ` [PATCH v7 net-next 13/13] gtp: Allow configuring GTP interface as standalone Tom Herbert
2017-10-28 8:09 ` Harald Welte [this message]
2017-10-28 16:16 ` [PATCH v7 net-next 00/13] gtp: Additional feature support - Part I Tom Herbert
2017-10-28 16:47 ` Harald Welte
2017-10-28 18:37 ` Tom Herbert
2017-10-29 1:49 ` David Miller
2017-11-12 20:56 ` Harald Welte
2017-11-13 0:25 ` Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171028080940.dvtzn2cg2rrk6f6t@nataraja \
--to=laforge@gnumonks.org \
--cc=aschultz@tpip.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=rohit@quantonium.net \
--cc=tom@quantonium.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox