From: David Miller <davem@davemloft.net>
To: john.fastabend@gmail.com
Cc: alexei.starovoitov@gmail.com, netdev@vger.kernel.org,
edumazet@google.com, daniel@iogearbox.net
Subject: Re: [net PATCH 0/2] sockmap fixes
Date: Sun, 29 Oct 2017 11:19:06 +0900 (KST) [thread overview]
Message-ID: <20171029.111906.598299267651559854.davem@davemloft.net> (raw)
In-Reply-To: <20171027163830.28498.82997.stgit@john-Precision-Tower-5810>
From: John Fastabend <john.fastabend@gmail.com>
Date: Fri, 27 Oct 2017 09:45:16 -0700
> Last two fixes (as far as I know) for sockmap code this round.
>
> First, we are using the qdisc cb structure when making the data end
> calculation. This is really just wrong so, store it with the other
> metadata in the correct tcp_skb_cb sturct to avoid breaking things.
>
> Next, with recent work to attach multiple programs to a cgroup a
> specific enumeration of return codes was agreed upon. However,
> I wrote the sk_skb program types before seeing this work and used
> a different convention. Patch 2 in the series aligns the return
> codes to avoid breaking with this infrastructure and also aligns
> with other programming conventions to avoid being the odd duck out
> forcing programs to remember SK_SKB programs are different. Pusing
> to net because its a user visible change. With this SK_SKB program
> return codes are the same as other cgroup program types.
Series applied, thanks a lot John.
prev parent reply other threads:[~2017-10-29 2:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 16:45 [net PATCH 0/2] sockmap fixes John Fastabend
2017-10-27 16:45 ` [net PATCH 1/2] bpf: bpf_compute_data uses incorrect cb structure John Fastabend
2017-10-27 19:43 ` Alexei Starovoitov
2017-10-27 16:45 ` [net PATCH 2/2] bpf: rename sk_actions to align with bpf infrastructure John Fastabend
2017-10-27 19:44 ` Alexei Starovoitov
2017-10-29 2:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171029.111906.598299267651559854.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox