From: kbuild test robot <lkp@intel.com>
To: Manish Kurup <kurup.manish@gmail.com>
Cc: kbuild-all@01.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
jiri@resnulli.us, davem@davemloft.net, netdev@vger.kernel.org,
aring@mojatatu.com, mrv@mojatatu.com, kurup.manish@gmail.com,
Manish Kurup <manish.kurup@verizon.com>
Subject: Re: [PATCH net-next 2/2] net sched act_vlan: VLAN action rewrite to use RCU lock/unlock and update
Date: Sun, 29 Oct 2017 07:22:48 +0800 [thread overview]
Message-ID: <201710290752.G27Wb3AP%fengguang.wu@intel.com> (raw)
In-Reply-To: <1509116964-8234-1-git-send-email-manish.kurup@verizon.com>
Hi Manish,
Thank you for the patch! Yet we hit a small issue.
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Manish-Kurup/net-sched-act_vlan-Change-stats-update-to-use-per-core-stats/20171029-053449
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
vim +70 drivers/net/ethernet/netronome/nfp/flower/action.c
1a1e586f Pieter Jansen van Vuuren 2017-06-29 55
1a1e586f Pieter Jansen van Vuuren 2017-06-29 56 static void
1a1e586f Pieter Jansen van Vuuren 2017-06-29 57 nfp_fl_push_vlan(struct nfp_fl_push_vlan *push_vlan,
1a1e586f Pieter Jansen van Vuuren 2017-06-29 58 const struct tc_action *action)
1a1e586f Pieter Jansen van Vuuren 2017-06-29 59 {
1a1e586f Pieter Jansen van Vuuren 2017-06-29 60 size_t act_size = sizeof(struct nfp_fl_push_vlan);
1a1e586f Pieter Jansen van Vuuren 2017-06-29 61 struct tcf_vlan *vlan = to_vlan(action);
1a1e586f Pieter Jansen van Vuuren 2017-06-29 62 u16 tmp_push_vlan_tci;
1a1e586f Pieter Jansen van Vuuren 2017-06-29 63
62d3f60b Pieter Jansen van Vuuren 2017-10-20 64 push_vlan->head.jump_id = NFP_FL_ACTION_OPCODE_PUSH_VLAN;
62d3f60b Pieter Jansen van Vuuren 2017-10-20 65 push_vlan->head.len_lw = act_size >> NFP_FL_LW_SIZ;
1a1e586f Pieter Jansen van Vuuren 2017-06-29 66 push_vlan->reserved = 0;
1a1e586f Pieter Jansen van Vuuren 2017-06-29 67 push_vlan->vlan_tpid = tcf_vlan_push_proto(action);
1a1e586f Pieter Jansen van Vuuren 2017-06-29 68
1a1e586f Pieter Jansen van Vuuren 2017-06-29 69 tmp_push_vlan_tci =
1a1e586f Pieter Jansen van Vuuren 2017-06-29 @70 FIELD_PREP(NFP_FL_PUSH_VLAN_PRIO, vlan->tcfv_push_prio) |
1a1e586f Pieter Jansen van Vuuren 2017-06-29 71 FIELD_PREP(NFP_FL_PUSH_VLAN_VID, vlan->tcfv_push_vid) |
1a1e586f Pieter Jansen van Vuuren 2017-06-29 72 NFP_FL_PUSH_VLAN_CFI;
1a1e586f Pieter Jansen van Vuuren 2017-06-29 73 push_vlan->vlan_tci = cpu_to_be16(tmp_push_vlan_tci);
1a1e586f Pieter Jansen van Vuuren 2017-06-29 74 }
1a1e586f Pieter Jansen van Vuuren 2017-06-29 75
:::::: The code at line 70 was first introduced by commit
:::::: 1a1e586f54bfe54a0ba7ea0ac9b8c7b1d3e655f6 nfp: add basic action capabilities to flower offloads
:::::: TO: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>
:::::: CC: David S. Miller <davem@davemloft.net>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2017-10-28 23:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 15:09 [PATCH net-next 2/2] net sched act_vlan: VLAN action rewrite to use RCU lock/unlock and update Manish Kurup
2017-10-28 22:21 ` kbuild test robot
2017-10-28 23:22 ` kbuild test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-10-26 19:11 Manish Kurup
2017-10-11 2:33 Manish Kurup
2017-10-11 12:28 ` Jamal Hadi Salim
2017-10-11 13:10 ` Eric Dumazet
2017-10-11 13:30 ` Eric Dumazet
2017-10-11 13:13 ` Jiri Pirko
2017-10-11 16:27 ` Cong Wang
2017-10-11 20:41 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201710290752.G27Wb3AP%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=aring@mojatatu.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kbuild-all@01.org \
--cc=kurup.manish@gmail.com \
--cc=manish.kurup@verizon.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox