Re: [patch net-next 2/4] net: sched: move the can_offload check from binding phase to rule insertion phase

David Miller
2017-10-26T01:01:40Z

From: Jiri Pirko <jiri@resnulli.us>
Date: Wed, 25 Oct 2017 16:34:58 +0200

> From: Jiri Pirko <jiri@mellanox.com>
>
> This restores the original behaviour before the block callbacks were
> introduced. Allow the drivers to do binding of block always, no matter
> if the NETIF_F_HW_TC feature is on or off. Move the check to the block
> callback which is called for rule insertion.
>
> Reported-by: Alexander Duyck <alexander.duyck@gmail.com>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>

I agree with Jakub's feedback, if every callback has to make this check
why not just do it in the core where the callback is invoked?