Re: [patch net-next 2/4] net: sched: move the can_offload check from binding phase to rule insertion phase

Jakub Kicinski
2017-10-25T22:09:30Z

On Wed, 25 Oct 2017 16:34:58 +0200, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@mellanox.com>
>
> This restores the original behaviour before the block callbacks were
> introduced. Allow the drivers to do binding of block always, no matter
> if the NETIF_F_HW_TC feature is on or off. Move the check to the block
> callback which is called for rule insertion.
>
> Reported-by: Alexander Duyck <alexander.duyck@gmail.com>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>

Could you explain why not add this check to the core? IIUC every
driver will have to duplicate it if we want to keep the behaviour
of tc offloads we have today.