From: David Miller <davem@davemloft.net>
To: yi.y.yang@intel.com
Cc: netdev@vger.kernel.org, dev@openvswitch.org, jbenc@redhat.com,
e@erig.me, pshelar@ovn.org
Subject: Re: [PATCH net-next v13] openvswitch: enable NSH support
Date: Mon, 30 Oct 2017 10:01:34 +0900 (KST) [thread overview]
Message-ID: <20171030.100134.1999494058214685235.davem@davemloft.net> (raw)
In-Reply-To: <1509003916-31897-1-git-send-email-yi.y.yang@intel.com>
From: Yi Yang <yi.y.yang@intel.com>
Date: Thu, 26 Oct 2017 15:45:16 +0800
> OVS master and 2.8 branch has merged NSH userspace
> patch series, this patch is to enable NSH support
> in kernel data path in order that OVS can support
> NSH in compat mode by porting this.
>
> Signed-off-by: Yi Yang <yi.y.yang@intel.com>
One small request for function naming:
> diff --git a/include/net/nsh.h b/include/net/nsh.h
> index a1eaea2..7dcf377 100644
> --- a/include/net/nsh.h
> +++ b/include/net/nsh.h
> @@ -304,4 +304,7 @@ static inline void nsh_set_flags_ttl_len(struct nshhdr *nsh, u8 flags,
> NSH_FLAGS_MASK | NSH_TTL_MASK | NSH_LEN_MASK);
> }
>
> +int skb_push_nsh(struct sk_buff *skb, const struct nshhdr *pushed_nh);
> +int skb_pop_nsh(struct sk_buff *skb);
> +
> #endif /* __NET_NSH_H */
All functions named "skb_*" should be core SKB handling functions found
and implemented in include/linux/skbuff.h and net/core/skbuff.c
Protocol specific helpers like this should be named "$PROTOCOL_NAME_*"
so please renamed these something like "nsh_header_push()" and
"nsh_header_pop()".
Thank you.
next prev parent reply other threads:[~2017-10-30 1:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 7:45 [PATCH net-next v13] openvswitch: enable NSH support Yi Yang
2017-10-30 1:01 ` David Miller [this message]
2017-10-30 1:34 ` Yang, Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171030.100134.1999494058214685235.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=e@erig.me \
--cc=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=yi.y.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).