netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: "David S. Miller" <davem@davemloft.net>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	netdev@vger.kernel.org
Subject: Re: [REGRESSION, BISECTED] Broken networking with net/phy/marvell
Date: Mon, 30 Oct 2017 11:40:25 +0100	[thread overview]
Message-ID: <20171030104025.GA12275@lunn.ch> (raw)
In-Reply-To: <20171030001954.rlrbldsle7v5ti5p@darkstar.musicnaut.iki.fi>

On Mon, Oct 30, 2017 at 02:19:54AM +0200, Aaro Koskinen wrote:
> Hi,
> 
> On Sat, Oct 28, 2017 at 09:01:39PM +0200, Andrew Lunn wrote:
> > On Thu, Oct 26, 2017 at 03:28:36PM +0300, Aaro Koskinen wrote:
> > > When upgrading from v4.13 to v4.14-rc6 on OpenRD Client, the box loses
> > > network connectivity.
> > 
> > What exactly is the PHY in the OpenRD?
> 
> 88E1116R.
> 
> > Please can you print the value of mscr before it is changed.
> 
> [    3.377836] MSCR BEFORE: 00001070
> [    3.381176]  MSCR AFTER: 00001040
 
> > One possibility, is that the bootloader is setting the PHY to
> > rgmii-id.

So the initial value does seem to suggest the bootloader is setting
it.

 This is now getting cleared, where earlier it was
> > preserved. If this is true, it should be solved by adding
> > 
> > phy-mode = "rgmii-id" to the ethernet node in the device tree.
> 
> Ok, that seems to help:
> 
> [    3.377852] MSCR BEFORE: 00001070
> [    3.381189]  MSCR AFTER: 00001070

Great. Thanks for testing this. I don't like it regressing though, so
i want to see if it is possible to fix this without needing to add the
phy mode. I hope to look at this in the next couple of days.

    Thanks

	Andrew
 

      reply	other threads:[~2017-10-30 10:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-26 12:28 [REGRESSION, BISECTED] Broken networking with net/phy/marvell Aaro Koskinen
2017-10-26 13:12 ` Dan Carpenter
2017-10-26 14:06   ` Dan Carpenter
2017-10-28 19:01 ` Andrew Lunn
2017-10-30  0:19   ` Aaro Koskinen
2017-10-30 10:40     ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171030104025.GA12275@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=aaro.koskinen@iki.fi \
    --cc=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).