From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next 3/4] hv_netvsc: reset net_device_ctx->nvdev
 with rcu_assign_pointer()
Date: Tue, 31 Oct 2017 23:44:59 +0900 (KST)
Message-ID: <20171031.234459.546020444648753386.davem@davemloft.net>
References: <20171031134204.15287-4-vkuznets@redhat.com>
 <1509458998.3828.19.camel@edumazet-glaptop3.roam.corp.google.com>
 <8760avxtx5.fsf@vitty.brq.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: sthemmin@microsoft.com, eric.dumazet@gmail.com, netdev@vger.kernel.org,
 haiyangz@microsoft.com, linux-kernel@vger.kernel.org,
 devel@linuxdriverproject.org
To: vkuznets@redhat.com
Return-path: <driverdev-devel-bounces@linuxdriverproject.org>
In-Reply-To: <8760avxtx5.fsf@vitty.brq.redhat.com>
List-Unsubscribe: <http://driverdev.linuxdriverproject.org/mailman/options/driverdev-devel>,
 <mailto:driverdev-devel-request@linuxdriverproject.org?subject=unsubscribe>
List-Archive: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/>
List-Post: <mailto:driverdev-devel@linuxdriverproject.org>
List-Help: <mailto:driverdev-devel-request@linuxdriverproject.org?subject=help>
List-Subscribe: <http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel>,
 <mailto:driverdev-devel-request@linuxdriverproject.org?subject=subscribe>
Errors-To: driverdev-devel-bounces@linuxdriverproject.org
Sender: "devel" <driverdev-devel-bounces@linuxdriverproject.org>
List-Id: netdev.vger.kernel.org

From: Vitaly Kuznetsov <vkuznets@redhat.com>
Date: Tue, 31 Oct 2017 15:40:06 +0100

> Eric Dumazet <eric.dumazet@gmail.com> writes:
> 
>> On Tue, 2017-10-31 at 14:42 +0100, Vitaly Kuznetsov wrote:
>>> RCU_INIT_POINTER() is not suitable here as it doesn't give us ordering
>>> guarantees (see the comment in rcupdate.h). This is also not a hotpath.
>>> 
>>> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>>> ---
>>>  drivers/net/hyperv/netvsc.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
>>> index bfc79698b8f4..12efb3e34775 100644
>>> --- a/drivers/net/hyperv/netvsc.c
>>> +++ b/drivers/net/hyperv/netvsc.c
>>> @@ -560,7 +560,7 @@ void netvsc_device_remove(struct hv_device *device)
>>>  
>>>  	netvsc_revoke_buf(device, net_device);
>>>  
>>> -	RCU_INIT_POINTER(net_device_ctx->nvdev, NULL);
>>> +	rcu_assign_pointer(net_device_ctx->nvdev, NULL);
>>
>> I see no point for this patch.
>>
>> Setting a NULL pointer needs no barrier at all.
> 
> Oh, sorry, I got confused by the comment near RCU_INIT_POINTER() in
> rcupdate.h. Now looking at their definitions I see.
> 
> This patch can of course be dropped from the series.

Any time there is a change to the series, you must resubmit the entire
series.

Thank you.