* [PATCH] ieee802154: mrf24j40: fix incorrect mask in mrf24j40_stop
@ 2017-10-31 6:31 Gustavo A. R. Silva
2017-11-06 11:13 ` Stefan Schmidt
2017-11-06 15:33 ` Stefan Schmidt
0 siblings, 2 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2017-10-31 6:31 UTC (permalink / raw)
To: Alan Ott, Alexander Aring, Stefan Schmidt
Cc: linux-wpan, netdev, linux-kernel, Julia Lawall,
Gustavo A. R. Silva
It seems that this is a copy/paste error and the proper bit masking is:
BIT_TXNIE | BIT_RXIE
This issue was detected with the help of Coccinelle.
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Fixes: 7d840545e5b9 ("mrf24j40: replace magic numbers")
---
drivers/net/ieee802154/mrf24j40.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
index ee7084b..cf4788d 100644
--- a/drivers/net/ieee802154/mrf24j40.c
+++ b/drivers/net/ieee802154/mrf24j40.c
@@ -635,7 +635,7 @@ static void mrf24j40_stop(struct ieee802154_hw *hw)
/* Set TXNIE and RXIE. Disable Interrupts */
regmap_update_bits(devrec->regmap_short, REG_INTCON,
- BIT_TXNIE | BIT_TXNIE, BIT_TXNIE | BIT_TXNIE);
+ BIT_TXNIE | BIT_RXIE, BIT_TXNIE | BIT_RXIE);
}
static int mrf24j40_set_channel(struct ieee802154_hw *hw, u8 page, u8 channel)
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ieee802154: mrf24j40: fix incorrect mask in mrf24j40_stop
2017-10-31 6:31 [PATCH] ieee802154: mrf24j40: fix incorrect mask in mrf24j40_stop Gustavo A. R. Silva
@ 2017-11-06 11:13 ` Stefan Schmidt
2017-11-06 14:36 ` Alan Ott
2017-11-06 15:33 ` Stefan Schmidt
1 sibling, 1 reply; 4+ messages in thread
From: Stefan Schmidt @ 2017-11-06 11:13 UTC (permalink / raw)
To: Gustavo A. R. Silva, Alan Ott, Alexander Aring
Cc: linux-wpan, netdev, linux-kernel, Julia Lawall
Hello Alan.
On 10/31/2017 07:31 AM, Gustavo A. R. Silva wrote:
> It seems that this is a copy/paste error and the proper bit masking is:
> BIT_TXNIE | BIT_RXIE
>
> This issue was detected with the help of Coccinelle.
>
> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> Fixes: 7d840545e5b9 ("mrf24j40: replace magic numbers")
> ---
> drivers/net/ieee802154/mrf24j40.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
> index ee7084b..cf4788d 100644
> --- a/drivers/net/ieee802154/mrf24j40.c
> +++ b/drivers/net/ieee802154/mrf24j40.c
> @@ -635,7 +635,7 @@ static void mrf24j40_stop(struct ieee802154_hw *hw)
>
> /* Set TXNIE and RXIE. Disable Interrupts */
> regmap_update_bits(devrec->regmap_short, REG_INTCON,
> - BIT_TXNIE | BIT_TXNIE, BIT_TXNIE | BIT_TXNIE);
> + BIT_TXNIE | BIT_RXIE, BIT_TXNIE | BIT_RXIE);
> }
>
> static int mrf24j40_set_channel(struct ieee802154_hw *hw, u8 page, u8 channel)
>
Could you review this and give me your ack when you are happy so I can apply it to my tree?
regards
Stefan Schmidt
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ieee802154: mrf24j40: fix incorrect mask in mrf24j40_stop
2017-11-06 11:13 ` Stefan Schmidt
@ 2017-11-06 14:36 ` Alan Ott
0 siblings, 0 replies; 4+ messages in thread
From: Alan Ott @ 2017-11-06 14:36 UTC (permalink / raw)
To: Stefan Schmidt, Gustavo A. R. Silva, Alexander Aring
Cc: linux-wpan, netdev, linux-kernel, Julia Lawall
On 11/06/2017 06:13 AM, Stefan Schmidt wrote:
> Hello Alan.
>
> On 10/31/2017 07:31 AM, Gustavo A. R. Silva wrote:
>> It seems that this is a copy/paste error and the proper bit masking is:
>> BIT_TXNIE | BIT_RXIE
>>
>> This issue was detected with the help of Coccinelle.
>>
>> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> Fixes: 7d840545e5b9 ("mrf24j40: replace magic numbers")
>> ---
>> drivers/net/ieee802154/mrf24j40.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
>> index ee7084b..cf4788d 100644
>> --- a/drivers/net/ieee802154/mrf24j40.c
>> +++ b/drivers/net/ieee802154/mrf24j40.c
>> @@ -635,7 +635,7 @@ static void mrf24j40_stop(struct ieee802154_hw *hw)
>>
>> /* Set TXNIE and RXIE. Disable Interrupts */
>> regmap_update_bits(devrec->regmap_short, REG_INTCON,
>> - BIT_TXNIE | BIT_TXNIE, BIT_TXNIE | BIT_TXNIE);
>> + BIT_TXNIE | BIT_RXIE, BIT_TXNIE | BIT_RXIE);
>> }
>>
>> static int mrf24j40_set_channel(struct ieee802154_hw *hw, u8 page, u8 channel)
>>
>
> Could you review this and give me your ack when you are happy so I can apply it to my tree?
>
Acked-by: Alan Ott <alan@signal11.us>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ieee802154: mrf24j40: fix incorrect mask in mrf24j40_stop
2017-10-31 6:31 [PATCH] ieee802154: mrf24j40: fix incorrect mask in mrf24j40_stop Gustavo A. R. Silva
2017-11-06 11:13 ` Stefan Schmidt
@ 2017-11-06 15:33 ` Stefan Schmidt
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Schmidt @ 2017-11-06 15:33 UTC (permalink / raw)
To: Gustavo A. R. Silva, Alan Ott, Alexander Aring, Stefan Schmidt
Cc: linux-wpan, netdev, linux-kernel, Julia Lawall
Hello.
On 31.10.2017 07:31, Gustavo A. R. Silva wrote:
> It seems that this is a copy/paste error and the proper bit masking is:
> BIT_TXNIE | BIT_RXIE
>
> This issue was detected with the help of Coccinelle.
>
> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> Fixes: 7d840545e5b9 ("mrf24j40: replace magic numbers")
> ---
> drivers/net/ieee802154/mrf24j40.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
> index ee7084b..cf4788d 100644
> --- a/drivers/net/ieee802154/mrf24j40.c
> +++ b/drivers/net/ieee802154/mrf24j40.c
> @@ -635,7 +635,7 @@ static void mrf24j40_stop(struct ieee802154_hw *hw)
>
> /* Set TXNIE and RXIE. Disable Interrupts */
> regmap_update_bits(devrec->regmap_short, REG_INTCON,
> - BIT_TXNIE | BIT_TXNIE, BIT_TXNIE | BIT_TXNIE);
> + BIT_TXNIE | BIT_RXIE, BIT_TXNIE | BIT_RXIE);
> }
>
> static int mrf24j40_set_channel(struct ieee802154_hw *hw, u8 page, u8 channel)
>
This patch has been applied to the wpan-next tree and will be
part of the next pull request to net-next. Thanks!
regards
Stefan Schmidt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-06 15:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-31 6:31 [PATCH] ieee802154: mrf24j40: fix incorrect mask in mrf24j40_stop Gustavo A. R. Silva
2017-11-06 11:13 ` Stefan Schmidt
2017-11-06 14:36 ` Alan Ott
2017-11-06 15:33 ` Stefan Schmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).