From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kubakici@wp.pl>
Cc: Steve Lin <steven.lin1@broadcom.com>,
netdev@vger.kernel.org, jiri@mellanox.com, davem@davemloft.net,
michael.chan@broadcom.com, linville@tuxdriver.com,
gospo@broadcom.com, yuvalm@mellanox.com
Subject: Re: [PATCH net-next v5 01/10] devlink: Add permanent config parameter get/set operations
Date: Tue, 31 Oct 2017 10:00:24 +0100 [thread overview]
Message-ID: <20171031090024.GE1972@nanopsycho.orion> (raw)
In-Reply-To: <20171031010418.78fd4db1@laptop>
Tue, Oct 31, 2017 at 09:04:18AM CET, kubakici@wp.pl wrote:
>On Tue, 31 Oct 2017 08:17:30 +0100, Jiri Pirko wrote:
>> Mon, Oct 30, 2017 at 11:12:13PM CET, kubakici@wp.pl wrote:
>> >On Mon, 30 Oct 2017 18:03:01 +0100, Jiri Pirko wrote:
>> >I'm not sure what the status of the reconfig trigger patches for mlxsw
>> >is, but we actually may need 3 config sets:
>> > - current/runtime configurable,
>> > - requiring soft reset of the device/driver reinit;
>> > - requiring hard reset/set on boot.
>> >
>> >Secondly, IMHO calling set/get parameters "permanent" is a bit
>> >backwards. One device may not be able to change max VF counts or MSIX
>> >allocation without full reinit of PCIe blocks, but for others soft
>> >reset is more than enough. Port splitting is another example. For
>> >NICs port splitting at runtime is usually not a priority in HW/FW
>> >development, so some form of reset is generally required, while
>> >switches can split a port at runtime. IOW we should define parameters
>> >without assigning them to config sets in the ABI itself. And also we
>> >should make it in a way which will allow existing parameters to be
>> >reused in permanent/sort reset required/runtime modes.
>> >
>> >Does that make sense?
>>
>> "IOW we should define parameters without assigning them to config sets
>> in the ABI itself" - I don't understand what do you mean by this.
>
>OK, whether the setting is permanent or not - is device specific.
>
>I'm basically asking to remove the "PERM" from the names and indicate
>which config set (of the 3 enumerated above) user wants it applied in a
>separate attribute.
Yesh, would be good if driver could indicate which option is of what
type and devlink should expose this information to the user.
But it probably should be flags. Driver may provide possibility to
configure for example VF count as runtime and also permanent option.
User should pass the correct flags along the set message so the driver
knows what to set. Makes sense?
next prev parent reply other threads:[~2017-10-31 9:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 14:46 [PATCH net-next v5 00/10] Adding permanent config get/set to devlink Steve Lin
2017-10-30 14:46 ` [PATCH net-next v5 01/10] devlink: Add permanent config parameter get/set operations Steve Lin
2017-10-30 17:03 ` Jiri Pirko
2017-10-30 20:17 ` Steve Lin
2017-10-30 22:12 ` Jakub Kicinski
2017-10-31 7:17 ` Jiri Pirko
2017-10-31 8:04 ` Jakub Kicinski
2017-10-31 9:00 ` Jiri Pirko [this message]
2017-10-31 18:48 ` Jakub Kicinski
2017-10-30 14:46 ` [PATCH net-next v5 02/10] devlink: Adding SR-IOV enablement perm config param Steve Lin
2017-10-30 17:20 ` Jiri Pirko
2017-10-30 20:17 ` Steve Lin
2017-10-31 7:12 ` Jiri Pirko
2017-10-30 14:46 ` [PATCH net-next v5 03/10] devlink: Adding num VFs per PF permanent " Steve Lin
2017-10-30 14:46 ` [PATCH net-next v5 04/10] devlink: Adding max PF MSI-X vectors perm " Steve Lin
2017-10-30 14:46 ` [PATCH net-next v5 05/10] devlink: Adding num MSI-X vectors per VF " Steve Lin
2017-10-30 14:46 ` [PATCH net-next v5 06/10] bnxt: Add devlink support for config get/set Steve Lin
2017-10-30 17:35 ` Jiri Pirko
2017-10-30 20:20 ` Steve Lin
2017-10-31 7:19 ` Jiri Pirko
2017-10-30 14:46 ` [PATCH net-next v5 07/10] bnxt: Adding SR-IOV enablement permanent cfg param Steve Lin
2017-10-30 14:46 ` [PATCH net-next v5 08/10] bnxt: Adding num VFs per PF perm config param Steve Lin
2017-10-30 14:46 ` [PATCH net-next v5 09/10] bnxt: Adding max PF MSI-X vectors " Steve Lin
2017-10-30 14:46 ` [PATCH net-next v5 10/10] bnxt: Adding num MSI-X vectors per VF " Steve Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031090024.GE1972@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=gospo@broadcom.com \
--cc=jiri@mellanox.com \
--cc=kubakici@wp.pl \
--cc=linville@tuxdriver.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=steven.lin1@broadcom.com \
--cc=yuvalm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).