From: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>
To: Manish Kurup <kurup.manish@gmail.com>
Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
jakub.kicinski@netronome.com, simon.horman@netronome.com,
john.hurley@netronome.com, oss-drivers@netronome.com,
davem@davemloft.net, netdev@vger.kernel.org, aring@mojatatu.com,
mrv@mojatatu.com, Manish Kurup <manish.kurup@verizon.com>
Subject: Re: [PATCH net-next v3 2/2] net sched act_vlan: VLAN action rewrite to use RCU lock/unlock and update
Date: Tue, 31 Oct 2017 13:06:45 +0000 [thread overview]
Message-ID: <20171031130645.07c58fdd@pieter-Netronome> (raw)
In-Reply-To: <1509266874-17013-1-git-send-email-manish.kurup@verizon.com>
On Sun, 29 Oct 2017 04:47:54 -0400
Manish Kurup <kurup.manish@gmail.com> wrote:
> Using a spinlock in the VLAN action causes performance issues when the VLAN
> action is used on multiple cores. Rewrote the VLAN action to use RCU read
> locking for reads and updates instead.
> Fixed nxp flower action to use VLAN helper functions instead of accessing the
> structure directly (build break error).
Thank you Manish. One minor nit, I think you meant nfp flower action...
Also is it possible to split this patch into 2 patches, it seems to do 2 things:
1. Update the VLAN action to use RCU.
2. Fix the nfp flower action to use the VLAN helper.
Can you please dump the build break error you are seeing here?
...
next prev parent reply other threads:[~2017-10-31 13:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 8:47 [PATCH net-next v3 2/2] net sched act_vlan: VLAN action rewrite to use RCU lock/unlock and update Manish Kurup
2017-10-31 13:06 ` Pieter Jansen van Vuuren [this message]
[not found] ` <CAJrKpLaANmT07o6S5zMe3LrOJgperyQeuEUgVdWkS3gZv5TwVw@mail.gmail.com>
2017-10-31 15:09 ` Pieter Jansen van Vuuren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031130645.07c58fdd@pieter-Netronome \
--to=pieter.jansenvanvuuren@netronome.com \
--cc=aring@mojatatu.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.hurley@netronome.com \
--cc=kurup.manish@gmail.com \
--cc=manish.kurup@verizon.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=simon.horman@netronome.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).